enhance: add active column for profile list cmd #14079

vharsh · 2022-05-01T16:13:24Z

Before:

➜  ~ minikube profile openebs
✅  minikube profile was successfully set to openebs
➜  ~ minikube profile list   
|----------|-----------|---------|--------------|------|---------|---------|-------|
| Profile  | VM Driver | Runtime |      IP      | Port | Version | Status  | Nodes |
|----------|-----------|---------|--------------|------|---------|---------|-------|
| minikube | docker    | docker  | 192.168.49.2 | 8443 | v1.20.2 | Stopped |     1 |
| openebs  | docker    | docker  | 192.168.58.2 | 8443 | v1.20.2 | Stopped |     1 |
|----------|-----------|---------|--------------|------|---------|---------|-------|

After:

➜  minikube git:(profileListFix) ✗ ./out/minikube profile list
|----------|-----------|---------|--------------|------|---------|---------|-------|--------|
| Profile  | VM Driver | Runtime |      IP      | Port | Version | Status  | Nodes | Active |
|----------|-----------|---------|--------------|------|---------|---------|-------|--------|
| minikube | docker    | docker  | 192.168.49.2 | 8443 | v1.20.2 | Stopped |     1 |        |
| openebs  | docker    | docker  | 192.168.58.2 | 8443 | v1.20.2 | Stopped |     1 | *      |
|----------|-----------|---------|--------------|------|---------|---------|-------|--------|
➜  minikube git:(profileListFix) ✗ minikube profile minikube
✅  minikube profile was successfully set to minikube
➜  minikube git:(profileListFix) ✗ ./out/minikube profile list
|----------|-----------|---------|--------------|------|---------|---------|-------|--------|
| Profile  | VM Driver | Runtime |      IP      | Port | Version | Status  | Nodes | Active |
|----------|-----------|---------|--------------|------|---------|---------|-------|--------|
| minikube | docker    | docker  | 192.168.49.2 | 8443 | v1.20.2 | Stopped |     1 | *      |
| openebs  | docker    | docker  | 192.168.58.2 | 8443 | v1.20.2 | Stopped |     1 |        |
|----------|-----------|---------|--------------|------|---------|---------|-------|--------|

➜  minikube git:(profileListFix) ✗ ./out/minikube profile list -ojson | jq | grep active
  "active": "minikube",

Signed-off-by: Harsh Vardhan harsh.vardhan@mayadata.io

k8s-ci-robot · 2022-05-01T16:13:31Z

Welcome @vharsh!

It looks like this is your first PR to kubernetes/minikube 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/minikube has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

k8s-ci-robot · 2022-05-01T16:13:32Z

Hi @vharsh. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

minikube-bot · 2022-05-01T16:14:03Z

Can one of the admins verify this patch?

vharsh · 2022-05-02T05:25:25Z

@medyagh PTAL, thanks.

cmd/minikube/cmd/config/profile_list.go

vharsh · 2022-05-14T17:01:28Z

@medyagh @spowelljr Can you approve the workflows now? Do the current changes look okay?

pkg/minikube/config/profile.go

spowelljr

I think it would be good to implement a small integration test to make sure that the JSON output is acting correctly. ie. Start a cluster, check that the correct cluster has Active: true, then change the active minikube profile <profile> and then check the JSON output again and make sure the Active: true changed.

vharsh · 2022-05-17T18:32:41Z

@spowelljr Should the minikube profile related tests go under serial functional tests, i.e. in the functional_test.go file?

vharsh · 2022-05-17T18:37:39Z

Okay, I think I've understood what I need to do.
I've got to create another file and create two minikube clusters with different profiles and check them out, I'll go ahead with this approach for now.

test/integration/minikube_profile_test.go

vharsh · 2022-05-26T10:12:23Z

test/integration/minikube_profile_test.go

+	// TODO(@vharsh): Figure out why go vet complains when this is moved into a loop
+	defer CleanupWithLogs(t, profiles[0], cancel)
+	defer CleanupWithLogs(t, profiles[1], cancel)


@spowelljr For some reason calling CleanupWithLogs with the cancel func reference inside a for loop triggers warnings but calling it outside one doesn't.

The exact error: the cancel function is not used on all paths (possible context leak)

My guess is that it's assuming that profiles could be empty (even though that's not possible) and that cancel would never be called. Could maybe try doing defer cancel.Cancel() right after ctx, cancel := context.WithTimeout and then putting CleanupWithLogs back in the for loop.

test/integration/minikube_profile_test.go

spowelljr · 2022-05-31T16:42:27Z

/ok-to-test

minikube-pr-bot · 2022-05-31T17:38:34Z

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 14079) |
+----------------+----------+---------------------+
| minikube start | 52.8s    | 51.9s               |
| enable ingress | 28.5s    | 27.5s               |
+----------------+----------+---------------------+

Times for minikube start: 53.0s 51.6s 54.1s 52.3s 53.0s
Times for minikube (PR 14079) start: 52.3s 52.1s 51.9s 51.4s 51.9s

Times for minikube ingress: 31.1s 28.2s 28.7s 25.2s 29.2s
Times for minikube (PR 14079) ingress: 28.6s 27.2s 25.1s 26.7s 29.7s

docker driver with docker runtime
error collecting results for docker driver: timing run 0 with minikube: timing cmd: [out/minikube addons enable ingress]: waiting for minikube: exit status 10
docker driver with containerd runtime
error collecting results for docker driver: timing run 0 with minikube: timing cmd: [out/minikube addons enable ingress]: waiting for minikube: exit status 10

spowelljr · 2022-05-31T18:22:56Z

test/integration/minikube_profile_test.go

+	defer CleanupWithLogs(t, profiles[0], cancel)
+	defer CleanupWithLogs(t, profiles[1], cancel)
+	for _, p := range profiles {
+		rr, err := Run(t, exec.CommandContext(ctx, Target(), "start", "-p", p))


Will need to append StartArgs() to the args list, then pass the args list into the command.

args := append([]string{"start", "-p", p}, StartArgs()...) rr, err := Run(t, exec.CommandContext(ctx, Target(), args...))

Okay, I believe StartArgs() are the things which are making the E2E run with different minikube-drivers, I'll just add StartArgs() call to all minikube start operations in my test.

minikube-pr-bot · 2022-05-31T20:06:38Z

These are the flake rates of all failed tests.

Environment	Failed Tests	Flake Rate (%)
none_Linux	TestMinikubeProfile (gopogh)	n/a
Docker_Linux_containerd	TestStartStop/group/newest-cni/serial/Pause (gopogh)	0.00 (chart)
Docker_macOS	TestIngressAddonLegacy/serial/ValidateIngressDNSAddonActivation (gopogh)	0.00 (chart)
Docker_macOS	TestPause/serial/VerifyStatus (gopogh)	0.00 (chart)
Docker_macOS	TestPreload (gopogh)	0.00 (chart)
Docker_Windows	TestNetworkPlugins/group/false/KubeletFlags (gopogh)	0.00 (chart)
Docker_Windows	TestPause/serial/VerifyDeletedResources (gopogh)	0.00 (chart)
Docker_macOS	TestIngressAddonLegacy/StartLegacyK8sCluster (gopogh)	1.00 (chart)
Docker_macOS	TestIngressAddonLegacy/serial/ValidateIngressAddonActivation (gopogh)	1.01 (chart)
Hyper-V_Windows	TestStartStop/group/default-k8s-different-port/serial/Pause (gopogh)	3.26 (chart)
Docker_macOS	TestRunningBinaryUpgrade (gopogh)	9.09 (chart)
Docker_Windows	TestFunctional/parallel/TunnelCmd/serial/WaitService/IngressIP (gopogh)	11.11 (chart)
Docker_macOS	TestMissingContainerUpgrade (gopogh)	12.12 (chart)
Docker_Windows	TestNetworkPlugins/group/auto/DNS (gopogh)	13.46 (chart)
Docker_macOS	TestFunctional/parallel/DashboardCmd (gopogh)	15.00 (chart)
Docker_Cloud_Shell	TestStartStop/group/cloud-shell/serial/AddonExistsAfterStop (gopogh)	15.18 (chart)
Docker_Cloud_Shell	TestStartStop/group/cloud-shell/serial/EnableAddonAfterStop (gopogh)	15.18 (chart)
Docker_Cloud_Shell	TestStartStop/group/cloud-shell/serial/SecondStart (gopogh)	15.18 (chart)
Docker_Cloud_Shell	TestStartStop/group/cloud-shell/serial/Stop (gopogh)	15.18 (chart)
Docker_Cloud_Shell	TestStartStop/group/cloud-shell/serial/UserAppExistsAfterStop (gopogh)	15.18 (chart)
Docker_macOS	TestKubernetesUpgrade (gopogh)	16.16 (chart)
Docker_macOS	TestStoppedBinaryUpgrade/Upgrade (gopogh)	18.56 (chart)
Docker_Linux_containerd	TestStartStop/group/no-preload/serial/DeployApp (gopogh)	35.90 (chart)
Docker_Linux_containerd	TestStartStop/group/no-preload/serial/FirstStart (gopogh)	36.71 (chart)
Docker_Linux_containerd	TestStartStop/group/no-preload/serial/UserAppExistsAfterStop (gopogh)	37.18 (chart)
Docker_Linux_containerd	TestStartStop/group/no-preload/serial/SecondStart (gopogh)	38.75 (chart)
Docker_Linux_containerd	TestStartStop/group/embed-certs/serial/FirstStart (gopogh)	42.31 (chart)
Docker_Linux_containerd	TestStartStop/group/embed-certs/serial/SecondStart (gopogh)	42.31 (chart)
Docker_macOS	TestStartStop/group/default-k8s-different-port/serial/Pause (gopogh)	42.86 (chart)
Docker_macOS	TestStartStop/group/newest-cni/serial/Pause (gopogh)	42.86 (chart)
More tests...	Continued...

Too many tests failed - See test logs for more details.

To see the flake rates of all tests by environment, click here.

Signed-off-by: Harsh Vardhan <harsh.vardhan@mayadata.io>

minikube-pr-bot · 2022-06-01T11:15:07Z

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 14079) |
+----------------+----------+---------------------+
| minikube start | 51.0s    | 50.7s               |
| enable ingress | 26.9s    | 27.9s               |
+----------------+----------+---------------------+

Times for minikube start: 52.1s 51.4s 49.0s 51.1s 51.4s
Times for minikube (PR 14079) start: 50.8s 49.9s 50.9s 51.0s 50.9s

Times for minikube ingress: 25.5s 30.1s 27.1s 25.5s 26.0s
Times for minikube (PR 14079) ingress: 28.5s 25.5s 30.0s 28.5s 27.1s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 14079) |
+----------------+----------+---------------------+
| minikube start | 27.6s    | 24.2s               |
| enable ingress | 22.0s    | 22.6s               |
+----------------+----------+---------------------+

Times for minikube start: 41.1s 24.6s 24.5s 23.6s 24.1s
Times for minikube (PR 14079) start: 24.3s 24.3s 23.7s 24.3s 24.5s

Times for minikube ingress: 19.9s 20.9s 21.9s 23.9s 23.4s
Times for minikube (PR 14079) ingress: 22.9s 22.4s 22.4s 22.0s 23.5s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 14079) |
+----------------+----------+---------------------+
| minikube start | 30.8s    | 34.5s               |
| enable ingress | 21.4s    | 22.8s               |
+----------------+----------+---------------------+

Times for minikube start: 33.6s 28.3s 32.1s 27.7s 32.2s
Times for minikube (PR 14079) start: 33.0s 32.0s 30.8s 44.3s 32.2s

Times for minikube ingress: 18.9s 31.4s 17.9s 20.9s 17.9s
Times for minikube (PR 14079) ingress: 19.0s 28.9s 21.4s 26.9s 17.9s

minikube-pr-bot · 2022-06-01T12:44:07Z

These are the flake rates of all failed tests.

Environment	Failed Tests	Flake Rate (%)
Docker_Windows	TestMinikubeProfile (gopogh)	n/a
Docker_macOS	TestIngressAddonLegacy/serial/ValidateIngressDNSAddonActivation (gopogh)	0.00 (chart)
Docker_macOS	TestPause/serial/VerifyStatus (gopogh)	0.00 (chart)
Docker_macOS	TestPreload (gopogh)	0.00 (chart)
Docker_Linux	TestNoKubernetes/serial/Start (gopogh)	1.00 (chart)
Docker_Linux	TestNoKubernetes/serial/Stop (gopogh)	1.00 (chart)
Docker_macOS	TestIngressAddonLegacy/StartLegacyK8sCluster (gopogh)	1.00 (chart)
Docker_macOS	TestIngressAddonLegacy/serial/ValidateIngressAddonActivation (gopogh)	1.01 (chart)
KVM_Linux_containerd	TestStoppedBinaryUpgrade/Upgrade (gopogh)	1.75 (chart)
Docker_Linux_containerd	TestNetworkPlugins/group/calico/NetCatPod (gopogh)	4.35 (chart)
Docker_Linux	TestNetworkPlugins/group/calico/NetCatPod (gopogh)	6.06 (chart)
Docker_Linux_containerd	TestNetworkPlugins/group/auto/Start (gopogh)	6.17 (chart)
Docker_macOS	TestRunningBinaryUpgrade (gopogh)	9.09 (chart)
KVM_Linux_containerd	TestPause/serial/SecondStartNoReconfiguration (gopogh)	9.65 (chart)
Hyper-V_Windows	TestNetworkPlugins/group/flannel/NetCatPod (gopogh)	10.14 (chart)
Docker_macOS	TestMissingContainerUpgrade (gopogh)	12.12 (chart)
Hyper-V_Windows	TestNetworkPlugins/group/enable-default-cni/Start (gopogh)	13.04 (chart)
Docker_macOS	TestKubernetesUpgrade (gopogh)	16.16 (chart)
Docker_macOS	TestStoppedBinaryUpgrade/Upgrade (gopogh)	18.56 (chart)
Docker_Linux_containerd	TestStartStop/group/old-k8s-version/serial/DeployApp (gopogh)	29.49 (chart)
Docker_Linux_containerd	TestStartStop/group/old-k8s-version/serial/FirstStart (gopogh)	29.49 (chart)
Docker_Linux_containerd	TestStartStop/group/old-k8s-version/serial/SecondStart (gopogh)	30.77 (chart)
Docker_Linux_containerd	TestStartStop/group/old-k8s-version/serial/UserAppExistsAfterStop (gopogh)	34.15 (chart)
Hyper-V_Windows	TestNetworkPlugins/group/bridge/Start (gopogh)	36.96 (chart)
Docker_Linux	TestNetworkPlugins/group/false/DNS (gopogh)	39.00 (chart)
Docker_Linux_containerd	TestStartStop/group/embed-certs/serial/FirstStart (gopogh)	42.31 (chart)
Docker_Linux_containerd	TestStartStop/group/embed-certs/serial/SecondStart (gopogh)	42.31 (chart)
Docker_macOS	TestStartStop/group/default-k8s-different-port/serial/Pause (gopogh)	42.86 (chart)
Docker_macOS	TestStartStop/group/newest-cni/serial/Pause (gopogh)	42.86 (chart)
Docker_macOS	TestStartStop/group/no-preload/serial/Pause (gopogh)	42.86 (chart)
More tests...	Continued...

Too many tests failed - See test logs for more details.

To see the flake rates of all tests by environment, click here.

vharsh · 2022-06-01T13:44:26Z

/retest

spowelljr · 2022-06-01T17:07:05Z

/retest-this-please

minikube-pr-bot · 2022-06-01T18:55:05Z

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 14079) |
+----------------+----------+---------------------+
| minikube start | 52.4s    | 51.3s               |
| enable ingress | 28.0s    | 29.9s               |
+----------------+----------+---------------------+

Times for minikube ingress: 28.1s 29.7s 28.2s 28.1s 26.1s
Times for minikube (PR 14079) ingress: 30.1s 29.6s 29.7s 30.6s 29.6s

Times for minikube start: 54.0s 51.3s 52.3s 52.4s 52.2s
Times for minikube (PR 14079) start: 51.4s 50.6s 51.0s 51.2s 52.4s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 14079) |
+----------------+----------+---------------------+
| minikube start | 26.3s    | 25.3s               |
| enable ingress | 22.9s    | 22.1s               |
+----------------+----------+---------------------+

Times for minikube start: 29.4s 25.1s 25.4s 25.3s 26.2s
Times for minikube (PR 14079) start: 24.5s 26.0s 25.1s 25.4s 25.4s

Times for minikube ingress: 23.5s 24.0s 21.4s 22.5s 22.9s
Times for minikube (PR 14079) ingress: 23.0s 20.5s 21.9s 22.5s 22.5s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 14079) |
+----------------+----------+---------------------+
| minikube start | 33.7s    | 32.7s               |
| enable ingress | 23.0s    | 22.8s               |
+----------------+----------+---------------------+

Times for minikube start: 32.0s 40.6s 30.1s 33.4s 32.7s
Times for minikube (PR 14079) start: 29.2s 32.6s 31.9s 40.4s 29.6s

Times for minikube ingress: 22.4s 22.4s 32.4s 18.9s 18.9s
Times for minikube (PR 14079) ingress: 21.9s 18.9s 18.5s 32.0s 22.5s

minikube-pr-bot · 2022-06-01T20:43:03Z

These are the flake rates of all failed tests.

Environment	Failed Tests	Flake Rate (%)
Docker_Windows	TestNoKubernetes/serial/Stop (gopogh)	0.00 (chart)
Hyper-V_Windows	TestStartStop/group/newest-cni/serial/Pause (gopogh)	0.93 (chart)
KVM_Linux_containerd	TestStoppedBinaryUpgrade/Upgrade (gopogh)	7.83 (chart)
Docker_macOS	TestDownloadOnlyKic (gopogh)	9.52 (chart)
Docker_macOS	TestDownloadOnly/v1.23.6/preload-exists (gopogh)	9.52 (chart)
Docker_Windows	TestPause/serial/PauseAgain (gopogh)	9.52 (chart)
Docker_Windows	TestNetworkPlugins/group/enable-default-cni/DNS (gopogh)	20.00 (chart)
Docker_Linux_containerd	TestAddons/Setup (gopogh)	20.86 (chart)
Docker_Linux_containerd	TestIngressAddonLegacy/serial/ValidateIngressAddonActivation (gopogh)	20.86 (chart)
Docker_Linux_containerd	TestIngressAddonLegacy/StartLegacyK8sCluster (gopogh)	20.86 (chart)
Docker_Linux_containerd	TestJSONOutput/start/Audit (gopogh)	20.86 (chart)
Docker_Linux_containerd	TestJSONOutput/start/Command (gopogh)	20.86 (chart)
Docker_Linux_containerd	TestMultiNode/serial/AddNode (gopogh)	20.86 (chart)
Docker_Linux_containerd	TestMultiNode/serial/DeleteNode (gopogh)	20.86 (chart)
Docker_Linux_containerd	TestMultiNode/serial/FreshStart2Nodes (gopogh)	20.86 (chart)
Docker_Linux_containerd	TestMultiNode/serial/ProfileList (gopogh)	20.86 (chart)
Docker_Linux_containerd	TestMultiNode/serial/RestartKeepsNodes (gopogh)	20.86 (chart)
Docker_Linux_containerd	TestMultiNode/serial/RestartMultiNode (gopogh)	20.86 (chart)
Docker_Linux_containerd	TestMultiNode/serial/StartAfterStop (gopogh)	20.86 (chart)
Docker_Linux_containerd	TestMultiNode/serial/StopNode (gopogh)	20.86 (chart)
Docker_Linux_containerd	TestPreload (gopogh)	20.86 (chart)
Docker_Windows	TestNetworkPlugins/group/kubenet/DNS (gopogh)	24.32 (chart)
Docker_Linux_containerd	TestOffline (gopogh)	25.15 (chart)
Docker_Linux_containerd	TestPause/serial/Start (gopogh)	26.38 (chart)
Docker_Linux_containerd	TestStartStop/group/old-k8s-version/serial/FirstStart (gopogh)	27.05 (chart)
Docker_Windows	TestNetworkPlugins/group/false/DNS (gopogh)	29.82 (chart)
Docker_Linux_containerd	TestFunctional/parallel/DashboardCmd (gopogh)	30.06 (chart)
Docker_Linux_containerd	TestFunctional/parallel/MountCmd/any-port (gopogh)	30.06 (chart)
Docker_Linux_containerd	TestFunctional/parallel/MySQL (gopogh)	30.06 (chart)
Docker_Linux_containerd	TestFunctional/parallel/PersistentVolumeClaim (gopogh)	30.06 (chart)
More tests...	Continued...

Too many tests failed - See test logs for more details.

To see the flake rates of all tests by environment, click here.

k8s-ci-robot · 2022-06-01T22:29:38Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: spowelljr, vharsh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [spowelljr]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot added do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels May 1, 2022

k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label May 1, 2022

k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label May 1, 2022

k8s-ci-robot requested review from afbjorklund and klaases May 1, 2022 16:13

vharsh force-pushed the profileListFix branch from 557bc46 to 319322e Compare May 1, 2022 16:15

k8s-ci-robot removed the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label May 1, 2022

vharsh force-pushed the profileListFix branch from 319322e to 09a508e Compare May 1, 2022 16:30

k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 1, 2022

medyagh requested changes May 2, 2022

View reviewed changes

cmd/minikube/cmd/config/profile_list.go Show resolved Hide resolved

vharsh force-pushed the profileListFix branch from 09a508e to b1df2dd Compare May 4, 2022 06:34

k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 4, 2022

vharsh requested review from medyagh and spowelljr May 4, 2022 06:47

vharsh force-pushed the profileListFix branch from b1df2dd to 3ab2e06 Compare May 12, 2022 06:54

vharsh force-pushed the profileListFix branch from 3ab2e06 to e171a34 Compare May 15, 2022 10:04

spowelljr requested changes May 16, 2022

View reviewed changes

pkg/minikube/config/profile.go Show resolved Hide resolved

pkg/minikube/config/profile.go Show resolved Hide resolved

spowelljr requested changes May 17, 2022

View reviewed changes

vharsh force-pushed the profileListFix branch from e171a34 to 12bbfd4 Compare May 24, 2022 06:38

k8s-ci-robot removed the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label May 24, 2022

spowelljr reviewed May 26, 2022

View reviewed changes

test/integration/minikube_profile_test.go Show resolved Hide resolved

vharsh force-pushed the profileListFix branch from cf98002 to ca8f9a7 Compare May 30, 2022 16:18

vharsh commented May 30, 2022

View reviewed changes

vharsh requested a review from spowelljr May 30, 2022 16:19

spowelljr reviewed May 31, 2022

View reviewed changes

test/integration/minikube_profile_test.go Outdated Show resolved Hide resolved

k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 31, 2022

spowelljr reviewed May 31, 2022

View reviewed changes

Harsh Vardhan added 7 commits June 1, 2022 15:28

enhance: add active column for profile list cmd

2dc84b1

Signed-off-by: Harsh Vardhan <harsh.vardhan@mayadata.io>

enhance: add json key for profile list cmd

066f731

Signed-off-by: Harsh Vardhan <harsh.vardhan@mayadata.io>

add active field in config.Profiles

a23d47b

Signed-off-by: Harsh Vardhan <harsh.vardhan@mayadata.io>

add integration test for json format profile list

d88a925

Signed-off-by: Harsh Vardhan <harsh.vardhan@mayadata.io>

reduce test timeout & fix lint issues

b77ecbe

Signed-off-by: Harsh Vardhan <harsh.vardhan@mayadata.io>

fix error logging

3d7380b

Signed-off-by: Harsh Vardhan <harsh.vardhan@mayadata.io>

add the StartArgs() suffix as supplied by test suite

798c4e8

Signed-off-by: Harsh Vardhan <harsh.vardhan@mayadata.io>

vharsh force-pushed the profileListFix branch from bc72781 to 798c4e8 Compare June 1, 2022 09:59

spowelljr approved these changes Jun 1, 2022

View reviewed changes

spowelljr merged commit 919e0da into kubernetes:master Jun 1, 2022

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 1, 2022

vharsh deleted the profileListFix branch June 2, 2022 16:11

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

enhance: add active column for profile list cmd #14079

enhance: add active column for profile list cmd #14079

vharsh commented May 1, 2022 •

edited

Loading

k8s-ci-robot commented May 1, 2022

k8s-ci-robot commented May 1, 2022

minikube-bot commented May 1, 2022

vharsh commented May 2, 2022

vharsh commented May 14, 2022

spowelljr left a comment

vharsh commented May 17, 2022

vharsh commented May 17, 2022

vharsh May 26, 2022

spowelljr May 31, 2022

spowelljr commented May 31, 2022

minikube-pr-bot commented May 31, 2022

spowelljr May 31, 2022 •

edited

Loading

vharsh Jun 1, 2022

minikube-pr-bot commented May 31, 2022

minikube-pr-bot commented Jun 1, 2022

minikube-pr-bot commented Jun 1, 2022

vharsh commented Jun 1, 2022

spowelljr commented Jun 1, 2022

minikube-pr-bot commented Jun 1, 2022

minikube-pr-bot commented Jun 1, 2022

k8s-ci-robot commented Jun 1, 2022

enhance: add active column for profile list cmd #14079

enhance: add active column for profile list cmd #14079

Conversation

vharsh commented May 1, 2022 • edited Loading

k8s-ci-robot commented May 1, 2022

k8s-ci-robot commented May 1, 2022

minikube-bot commented May 1, 2022

vharsh commented May 2, 2022

vharsh commented May 14, 2022

spowelljr left a comment

Choose a reason for hiding this comment

vharsh commented May 17, 2022

vharsh commented May 17, 2022

vharsh May 26, 2022

Choose a reason for hiding this comment

spowelljr May 31, 2022

Choose a reason for hiding this comment

spowelljr commented May 31, 2022

minikube-pr-bot commented May 31, 2022

spowelljr May 31, 2022 • edited Loading

Choose a reason for hiding this comment

vharsh Jun 1, 2022

Choose a reason for hiding this comment

minikube-pr-bot commented May 31, 2022

minikube-pr-bot commented Jun 1, 2022

minikube-pr-bot commented Jun 1, 2022

vharsh commented Jun 1, 2022

spowelljr commented Jun 1, 2022

minikube-pr-bot commented Jun 1, 2022

minikube-pr-bot commented Jun 1, 2022

k8s-ci-robot commented Jun 1, 2022

vharsh commented May 1, 2022 •

edited

Loading

spowelljr May 31, 2022 •

edited

Loading