Update accessing apps service doc #13806

zhan9san · 2022-03-17T09:01:50Z

Would you kindly review this doc update?

k8s-ci-robot · 2022-03-17T09:01:58Z

Hi @zhan9san. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

minikube-bot · 2022-03-17T09:03:04Z

Can one of the admins verify this patch?

medyagh · 2022-03-22T17:07:24Z

site/content/en/docs/handbook/accessing.md

@@ -11,6 +11,8 @@ aliases:

 There are two major categories of services in Kubernetes:

+[publishing-services-service-types](https://kubernetes.io/docs/concepts/services-networking/service/#publishing-services-service-types)


this doesnt seem to be relevent,

it says
"
There are two major categories of services in Kubernetes:

[publishing-services-service-types]
"

Hi @medyagh

I though it may help users to access the kubernetes service type here.

This line has been removed and the PR is rebased on master branch.

Could you kindly review it again?

AlexIoannides · 2022-05-01T10:34:04Z

I found the information contained in the updated docs very useful and would have appreciated it in the latest (online) version.

spowelljr

Just grammatical and capitalization changes, I'll be happy to merge once addressed

spowelljr · 2022-05-13T22:41:01Z

site/content/en/docs/handbook/accessing.md

+
+### Example of NodePort
+
+1. Create a kubernetes deployment


Suggested change

1. Create a kubernetes deployment

1. Create a Kubernetes deployment

spowelljr · 2022-05-13T22:41:10Z

site/content/en/docs/handbook/accessing.md

+    kubectl create deployment hello-minikube1 --image=k8s.gcr.io/echoserver:1.4
+    ```
+
+2. Create a kubernetes service type NodePort


Suggested change

2. Create a kubernetes service type NodePort

2. Create a Kubernetes service type NodePort

spowelljr · 2022-05-13T22:41:31Z

site/content/en/docs/handbook/accessing.md

+    minikube service hello-minikube1 --url
+    ```
+
+    `minikube service hello-minikube1 --url` runs as a process, creating a [tunnel](https://en.wikipedia.org/wiki/Port_forwarding#Local_port_forwarding) to cluster. The command exposes the service directly to any program running on the host operating system.


Suggested change

`minikube service hello-minikube1 --url` runs as a process, creating a [tunnel](https://en.wikipedia.org/wiki/Port_forwarding#Local_port_forwarding) to cluster. The command exposes the service directly to any program running on the host operating system.

`minikube service hello-minikube1 --url` runs as a process, creating a [tunnel](https://en.wikipedia.org/wiki/Port_forwarding#Local_port_forwarding) to the cluster. The command exposes the service directly to any program running on the host operating system.

spowelljr · 2022-05-13T22:43:22Z

site/content/en/docs/handbook/accessing.md

+    </pre>
+    </details>
+
+    check ssh tunnel in another terminal


Suggested change

check ssh tunnel in another terminal

Check ssh tunnel in another terminal

spowelljr · 2022-05-13T22:43:29Z

site/content/en/docs/handbook/accessing.md

+
+5. Try in your browser
+
+    open in your browser (make sure there is no proxy set)


Suggested change

open in your browser (make sure there is no proxy set)

Open in your browser (ensure there is no proxy set)

spowelljr · 2022-05-13T22:47:23Z

site/content/en/docs/handbook/accessing.md

+    http://REPLACE_WITH_EXTERNAL_IP:8080
+    ```
+
+    Each service will get its own external ip.


Suggested change

Each service will get its own external ip.

Each service will get its own external IP.

spowelljr · 2022-05-13T22:49:45Z

site/content/en/docs/handbook/accessing.md

-## Getting the NodePort using kubectl
+### Using `minikube service` with tunnel
+
+The network is limited if you are using a Docker driver on darwin, Windows or WSL, and the Node IP is not reachable directly.


Suggested change

The network is limited if you are using a Docker driver on darwin, Windows or WSL, and the Node IP is not reachable directly.

The network is limited if using the Docker driver on Darwin, Windows, or WSL, and the Node IP is not reachable directly.

spowelljr · 2022-05-13T22:50:49Z

site/content/en/docs/handbook/accessing.md


-#### Run tunnel in a separate terminal
+1. Run tunnel in a separate terminal


Suggested change

1. Run tunnel in a separate terminal

1. Run the tunnel in a separate terminal

spowelljr · 2022-05-13T22:52:38Z

site/content/en/docs/handbook/accessing.md


-note that without minikube tunnel, kubernetes would be showing external IP as "pending".
+4. Check external IP


Suggested change

4. Check external IP

4. Check the external IP

spowelljr · 2022-05-13T22:55:10Z

site/content/en/docs/handbook/accessing.md

+
+The network is limited if you are using a Docker driver on darwin, Windows or WSL, and the Node IP is not reachable directly.
+
+If minikube runs on Linux with Docker driver, no tunnel will be created.


Suggested change

If minikube runs on Linux with Docker driver, no tunnel will be created.

Running minikube on Linux with the Docker driver will result in no tunnel being created.

zhan9san · 2022-05-17T08:40:36Z

Hi @spowelljr

Thanks for your careful review.
The suggested changes have been made.

Could you help review it again?

spowelljr

Looks good, thank you!

k8s-ci-robot · 2022-05-17T19:07:35Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: spowelljr, zhan9san

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [spowelljr]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 17, 2022

k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Mar 17, 2022

k8s-ci-robot requested review from prasadkatti and spowelljr March 17, 2022 09:02

medyagh reviewed Mar 22, 2022

View reviewed changes

update service doc

2b16bfd

zhan9san mentioned this pull request Mar 24, 2022

Help request: Please provide step by step instructions on using minikube tunnel for MacOS M1 Chips? #13207

Closed

zhan9san force-pushed the feature/update-service-doc branch from a23d3ac to 2b16bfd Compare March 24, 2022 13:03

zhan9san mentioned this pull request Apr 25, 2022

The terminal needs to be open to run it (mac M1) #14039

Closed

asungur mentioned this pull request Apr 25, 2022

add clear documentation that service command on MacOs/Windows needs active terminal seassion #9016

Closed

This was referenced Apr 25, 2022

Not able to expose with MacOS M1 chip #14041

Closed

不能访问通过NodePort暴露的Nginx服务 #13747

Closed

This was referenced May 4, 2022

Exposing endpoint with "minikube service <svc>" does not work #14097

Closed

Support Ingress on MacOS, driver docker #12089

Merged

services running on minikube cluster are inaccessible #13788

Closed

spowelljr requested changes May 13, 2022

View reviewed changes

Fix grammer issue

e539972

spowelljr approved these changes May 17, 2022

View reviewed changes

spowelljr merged commit c38987b into kubernetes:master May 17, 2022

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 17, 2022

zhan9san mentioned this pull request May 19, 2022

Cannoot access services via NodePort on MacOS with Docker driver #11193

Closed

zhan9san deleted the feature/update-service-doc branch May 19, 2022 03:25

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update accessing apps service doc #13806

Update accessing apps service doc #13806

zhan9san commented Mar 17, 2022

k8s-ci-robot commented Mar 17, 2022

minikube-bot commented Mar 17, 2022

medyagh Mar 22, 2022

zhan9san Mar 24, 2022

AlexIoannides commented May 1, 2022

spowelljr left a comment

spowelljr May 13, 2022

spowelljr May 13, 2022

spowelljr May 13, 2022

spowelljr May 13, 2022

spowelljr May 13, 2022

spowelljr May 13, 2022

spowelljr May 13, 2022

spowelljr May 13, 2022

spowelljr May 13, 2022

spowelljr May 13, 2022

zhan9san commented May 17, 2022

spowelljr left a comment

k8s-ci-robot commented May 17, 2022

		@@ -11,6 +11,8 @@ aliases:

		There are two major categories of services in Kubernetes:

		[publishing-services-service-types](https://kubernetes.io/docs/concepts/services-networking/service/#publishing-services-service-types)

	1. Create a kubernetes deployment
	1. Create a Kubernetes deployment

	2. Create a kubernetes service type NodePort
	2. Create a Kubernetes service type NodePort

	`minikube service hello-minikube1 --url` runs as a process, creating a [tunnel](https://en.wikipedia.org/wiki/Port_forwarding#Local_port_forwarding) to cluster. The command exposes the service directly to any program running on the host operating system.
	`minikube service hello-minikube1 --url` runs as a process, creating a [tunnel](https://en.wikipedia.org/wiki/Port_forwarding#Local_port_forwarding) to the cluster. The command exposes the service directly to any program running on the host operating system.

	check ssh tunnel in another terminal
	Check ssh tunnel in another terminal


		5. Try in your browser

		open in your browser (make sure there is no proxy set)

	open in your browser (make sure there is no proxy set)
	Open in your browser (ensure there is no proxy set)

	Each service will get its own external ip.
	Each service will get its own external IP.

	The network is limited if you are using a Docker driver on darwin, Windows or WSL, and the Node IP is not reachable directly.
	The network is limited if using the Docker driver on Darwin, Windows, or WSL, and the Node IP is not reachable directly.


		#### Run tunnel in a separate terminal
		1. Run tunnel in a separate terminal

	1. Run tunnel in a separate terminal
	1. Run the tunnel in a separate terminal


		note that without minikube tunnel, kubernetes would be showing external IP as "pending".
		4. Check external IP


		The network is limited if you are using a Docker driver on darwin, Windows or WSL, and the Node IP is not reachable directly.

		If minikube runs on Linux with Docker driver, no tunnel will be created.

	If minikube runs on Linux with Docker driver, no tunnel will be created.
	Running minikube on Linux with the Docker driver will result in no tunnel being created.

Update accessing apps service doc #13806

Update accessing apps service doc #13806

Conversation

zhan9san commented Mar 17, 2022

k8s-ci-robot commented Mar 17, 2022

minikube-bot commented Mar 17, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

AlexIoannides commented May 1, 2022

spowelljr left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

zhan9san commented May 17, 2022

spowelljr left a comment

Choose a reason for hiding this comment

k8s-ci-robot commented May 17, 2022