list all currently supported Kubernetes versions #13775
Conversation
k8s-ci-robot
added
cncf-cla: yes
k8s-ci-robot
added
the
approved
|
/ok-to-test |
k8s-ci-robot
added
the
ok-to-test
|
kvm2 driver with docker runtime Times for minikube start: 54.3s 52.0s 52.9s 55.3s 53.4s Times for minikube ingress: 30.0s 28.5s 29.1s 26.5s 26.1s docker driver with docker runtime Times for minikube start: 27.1s 25.4s 25.1s 25.9s 26.3s Times for minikube ingress: 21.9s 83.4s 82.9s 21.9s 25.9s docker driver with containerd runtime Times for minikube start: 34.8s 41.5s 46.2s 46.0s 41.2s Times for minikube ingress: 18.9s 23.4s 19.0s 18.9s 33.4s |
|
These are the flake rates of all failed tests.
To see the flake rates of all tests by environment, click here. |
|
What about adding the listing under “minikube config” there some config that list the list of possible values like driver |
|
One problem I see is the output of the list in JSON and YAML. For example, if the user wanted to get the latest k8s version with JSON they simply can't do |
thanks @spowelljr, I've amended pr to address this examples: |
thanks @csantanapr, yes, that might be an option too in latest coming i've moved it to the so, either this or the previous commit (using example outputs: |
|
kvm2 driver with docker runtime Times for minikube (PR 13775) ingress: 30.1s 28.5s 30.6s 27.0s 29.1s Times for minikube start: 54.7s 50.6s 52.9s 51.8s 52.2s docker driver with docker runtime Times for minikube start: 30.6s 25.7s 25.8s 25.8s 26.6s Times for minikube ingress: 26.9s 22.4s 23.5s 23.4s 23.9s docker driver with containerd runtime Times for minikube start: 34.6s 41.2s 45.0s 41.3s 45.6s Times for minikube ingress: 19.9s 23.4s 48.9s 23.4s 18.9s |
k8s-ci-robot
added
size/L
|
These are the flake rates of all failed tests.
Too many tests failed - See test logs for more details. To see the flake rates of all tests by environment, click here. |
|
kvm2 driver with docker runtime Times for minikube start: 54.3s 52.6s 52.7s 53.0s 52.5s Times for minikube (PR 13775) ingress: 37.6s 30.1s 30.1s 28.6s 30.6s docker driver with docker runtime Times for minikube start: 30.3s 26.4s 26.8s 26.8s 26.3s Times for minikube ingress: 21.9s 22.4s 23.9s 22.4s 23.5s docker driver with containerd runtime Times for minikube ingress: 20.9s 19.0s 22.9s 23.9s 19.0s Times for minikube start: 35.0s 46.9s 42.9s 42.1s 46.2s |
|
kvm2 driver with docker runtime Times for minikube ingress: 29.1s 29.1s 29.6s 26.0s 28.5s Times for minikube (PR 13775) start: 52.3s 51.6s 52.3s 52.2s 51.3s docker driver with docker runtime Times for minikube (PR 13775) ingress: 22.9s 20.9s 21.9s 22.9s 24.4s Times for minikube (PR 13775) start: 26.3s 25.7s 25.8s 26.3s 26.4s docker driver with containerd runtime Times for minikube ingress: 33.4s 24.4s 19.9s 23.4s 23.4s Times for minikube start: 30.5s 41.2s 45.1s 41.8s 41.3s |
|
These are the flake rates of all failed tests.
Too many tests failed - See test logs for more details. To see the flake rates of all tests by environment, click here. |
|
These are the flake rates of all failed tests.
Too many tests failed - See test logs for more details. To see the flake rates of all tests by environment, click here. |
k8s-ci-robot
added
the
needs-rebase
prezha
force-pushed
the
list-supported-k8s-versions
branch
from
4d572ef
to
66e7291
Compare
k8s-ci-robot
removed
the
needs-rebase
|
kvm2 driver with docker runtime Times for minikube start: 54.8s 50.4s 51.2s 50.1s 51.9s Times for minikube ingress: 29.0s 34.6s 30.6s 26.1s 31.6s docker driver with docker runtime Times for minikube (PR 13775) ingress: 22.9s 22.9s 22.9s 23.0s 22.9s Times for minikube start: 24.8s 24.9s 24.6s 24.7s 24.1s docker driver with containerd runtime Times for minikube start: 39.6s 44.0s 39.2s 39.8s 43.4s Times for minikube ingress: 23.4s 27.9s 23.4s 22.4s 17.9s |
|
These are the flake rates of all failed tests.
To see the flake rates of all tests by environment, click here. |
|
This |
thanks @sharifelgamal, sure, i've updated the pr's description accordingly |
k8s-ci-robot
added
the
needs-rebase
prezha
force-pushed
the
list-supported-k8s-versions
branch
from
66e7291
to
138dc9d
Compare
k8s-ci-robot
removed
the
needs-rebase
|
kvm2 driver with docker runtime Times for minikube (PR 13775) start: 50.4s 50.5s 50.6s 51.8s 50.9s Times for minikube ingress: 29.6s 30.0s 31.1s 31.1s 26.6s docker driver with docker runtime Times for minikube start: 24.4s 25.0s 24.2s 23.8s 25.2s Times for minikube ingress: 23.4s 22.9s 22.0s 22.4s 23.9s docker driver with containerd runtime Times for minikube start: 41.9s 43.6s 43.8s 43.7s 40.2s Times for minikube ingress: 22.4s 17.9s 22.4s 18.0s 32.4s |
|
|
||
| opts := &github.ListOptions{PerPage: 100} | ||
| for (opts.Page+1)*100 <= 300 { | ||
| rls, resp, err := ghc.Repositories.ListReleases(context.Background(), "kubernetes", "kubernetes", opts) |
There was a problem hiding this comment.
@prezha one of the use cases of this feature would be in the minikube GUI, when we load the page to create a cluster we can list all supported kubernetes versions, this will make a http call (not very cheap) in the gui.
i suggest this code to only reference the constants and if needed add some sort of automation (in Makefile) to generate this list. instead of making the call each single time.
is that reasonable?
There was a problem hiding this comment.
@medyagh that's a good use case as well
this func (exposed via CLI) takes ~1.7sec to produce a fresh list of all currently acceptable k8s versions, which indeed is not that cheap
now, the release cadence for minikube is ~monthly, whereas k8s (supporting the last 3 of its minor versions) has it more frequently, and therefore we/user could end up with the outdated static list (especially if a user did not upgrade to the latest minikube version)
i'd suggest keeping this func/cli functionality as-is in this pr, and for the GUI use case, we could ship minikube releases with a "hardcoded" list of all supported k8s versions (known at the time of the release) and also have eg, a "Refresh" link/button nearby to call this func again so that the GUI can regenerate and cache results for later reuse?
what do you think?
There was a problem hiding this comment.
As the person working on the GUI, on GUI startup we could make a call to this function and cache the result. So by the time the user gets around to starting the cluster with a custom k8s version, the list will already be cached and will be able to validate the users input with no latency. I'm not arguing the solution either way, but stating that I don't believe this will impact the GUI.
There was a problem hiding this comment.
@spowelljr yes, thanks, that sounds like a good/optimal solution to me
@medyagh would you agree then that we keep this func[tionality] as-is in this pr and Steven will call it as needed and also cache results on the gui side?
k8s-ci-robot
added
the
needs-rebase
prezha
force-pushed
the
list-supported-k8s-versions
branch
from
138dc9d
to
97dfef3
Compare
k8s-ci-robot
removed
the
needs-rebase
|
These are the flake rates of all failed tests.
To see the flake rates of all tests by environment, click here. |
k8s-ci-robot
added
the
needs-rebase
prezha
force-pushed
the
list-supported-k8s-versions
branch
from
97dfef3
to
cf3d33a
Compare
k8s-ci-robot
removed
the
needs-rebase
|
kvm2 driver with docker runtime Times for minikube start: 53.9s 51.8s 53.0s 52.1s 51.6s Times for minikube ingress: 29.2s 31.6s 28.7s 29.2s 29.5s docker driver with docker runtime Times for minikube start: 29.2s 26.2s 25.4s 25.2s 25.5s Times for minikube ingress: 23.0s 21.5s 24.0s 23.0s 23.0s docker driver with containerd runtime Times for minikube ingress: 22.5s 18.9s 22.5s 22.5s 22.0s Times for minikube start: 31.4s 42.7s 30.1s 30.0s 41.0s |
|
These are the flake rates of all failed tests.
Too many tests failed - See test logs for more details. To see the flake rates of all tests by environment, click here. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: prezha, spowelljr The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
fixes #13773
examples:
minikube config defaults