Fixes validation on image repository URL when it contains port but no scheme #13053
Conversation
|
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
|
k8s-ci-robot
added
the
cncf-cla: no
|
Welcome @tmcalves! |
|
Hi @tmcalves. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
k8s-ci-robot
added
needs-ok-to-test
|
Can one of the admins verify this patch? |
|
thank you @tmcalves for the PR, would u plz sign the CLA |
|
Should all be signed now |
k8s-ci-robot
added
cncf-cla: yes
|
anyone able to take a look at this? |
|
/ok-to-test |
k8s-ci-robot
added
ok-to-test
…t schema Refactor the way validations are done to use regular expression Explicitly use "auto" as the imageRepo instead of an empty string when URL received is invalid
tmcalves
force-pushed
the
validations_on_image_repository
branch
from
49368d3
to
a9d3fe2
Compare
|
Rebased to test a more updated version |
|
kvm2 driver with docker runtime Times for minikube start: 54.3s 53.1s 52.9s 51.7s 55.5s Times for minikube ingress: 28.5s 30.1s 29.1s 30.6s 26.6s docker driver with docker runtime Times for minikube start: 29.9s 26.5s 26.6s 26.3s 25.9s Times for minikube ingress: 23.0s 22.5s 22.9s 22.4s 23.5s docker driver with containerd runtime Times for minikube (PR 13053) start: 41.6s 45.8s 41.4s 46.4s 41.3s Times for minikube (PR 13053) ingress: 22.9s 18.9s 24.4s 19.4s 23.4s |
|
kvm2 driver with docker runtime Times for minikube (PR 13053) start: 52.7s 52.4s 52.3s 51.5s 52.4s Times for minikube ingress: 28.6s 28.6s 30.5s 28.5s 26.1s docker driver with docker runtime Times for minikube start: 29.8s 25.8s 27.1s 26.4s 26.0s Times for minikube (PR 13053) ingress: 22.4s 22.9s 23.9s 22.0s 22.4s docker driver with containerd runtime Times for minikube start: 30.1s 45.0s 40.5s 42.0s 42.0s Times for minikube ingress: 24.4s 18.9s 23.4s 23.4s 22.9s |
|
These are the flake rates of all failed tests.
Too many tests failed - See test logs for more details. To see the flake rates of all tests by environment, click here. |
|
These are the flake rates of all failed tests.
To see the flake rates of all tests by environment, click here. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: spowelljr, tmcalves The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Refactor the way validations are done to use regular expression
Explicitly use "auto" as the imageRepo instead of an empty string when URL received is invalid
Fixes #13022