-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add --no-kubernetes flag to start minikube without kubernetes #12848
Conversation
This would probably make more sense when using a --vm driver, if it says "without docker" ? Also the |
cmd/minikube/cmd/start.go
Outdated
register.Reg.SetStep(register.Done) | ||
out.Step(style.Ready, "Done! minikube is ready without Kubernetes!") | ||
out.BoxedWithConfig(box.Config{Py: 1, Px: 4, Type: "Round", Color: "Green"}, style.Tip, "Things to try without Kubernetes ...", `- "minikube ssh" to SSH into minikube's node. | ||
- "minikube docker-env" to build images by pointing to the docker inside minikube |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to check for the runtime being docker, so needs a parameter with the current setting
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was actualy aware of this I was gonna make a good first issue out of this for joey
/ok-to-test |
@afbjorklund thanks for the review, addressed the comments and created a good first issue #12857 |
Co-authored-by: Steven Powell <44844360+spowelljr@users.noreply.github.com>
Co-authored-by: Steven Powell <44844360+spowelljr@users.noreply.github.com>
Co-authored-by: Steven Powell <44844360+spowelljr@users.noreply.github.com>
Co-authored-by: Steven Powell <44844360+spowelljr@users.noreply.github.com>
Co-authored-by: Steven Powell <44844360+spowelljr@users.noreply.github.com>
Co-authored-by: Steven Powell <44844360+spowelljr@users.noreply.github.com>
Co-authored-by: Steven Powell <44844360+spowelljr@users.noreply.github.com>
/ok-to-test |
1 similar comment
/ok-to-test |
kvm2 driver with docker runtime
Times for minikube (PR 12848) start: 46.0s 47.1s 47.3s 48.8s 47.7s Times for minikube ingress: 32.3s 30.9s 31.8s 30.8s 31.8s docker driver with docker runtime
Times for minikube start: 22.8s 21.7s 21.4s 21.5s 21.5s Times for minikube ingress: 27.4s 26.4s 34.0s 25.9s 26.5s docker driver with containerd runtime
Times for minikube ingress: 28.4s 32.5s 32.4s 18.5s 32.9s Times for minikube start: 30.5s 43.3s 43.6s 43.6s 43.1s |
These are the flake rates of all failed tests.
To see the flake rates of all tests by environment, click here. |
Co-authored-by: Steven Powell <44844360+spowelljr@users.noreply.github.com>
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: medyagh, spowelljr The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kvm2 driver with docker runtime
Times for minikube start: 47.5s 46.4s 46.4s 45.8s 45.7s Times for minikube ingress: 30.8s 31.2s 30.2s 31.3s 31.8s docker driver with docker runtime
Times for minikube start: 20.8s 20.7s 20.8s 21.0s 21.1s Times for minikube ingress: 27.9s 27.4s 26.5s 27.4s 34.4s docker driver with containerd runtime
Times for minikube ingress: 29.4s 32.9s 28.9s 19.4s 19.9s Times for minikube start: 28.9s 43.2s 43.0s 43.8s 43.9s |
kvm2 driver with docker runtime
Times for minikube ingress: 31.4s 33.9s 36.8s 31.8s 30.8s Times for minikube start: 51.6s 47.2s 46.5s 46.4s 47.8s docker driver with docker runtime
Times for minikube start: 22.1s 22.2s 22.1s 22.0s 23.5s Times for minikube ingress: 34.0s 26.4s 28.0s 27.0s 26.0s docker driver with containerd runtime
Times for minikube start: 43.9s 43.8s 43.0s 43.8s 43.2s Times for minikube ingress: 28.0s 18.6s 25.0s 33.0s 22.6s |
kvm2 driver with docker runtime
Times for minikube start: 47.6s 47.5s 47.4s 46.8s 48.2s Times for minikube ingress: 32.8s 31.2s 31.8s 32.4s 35.8s docker driver with docker runtime
Times for minikube start: 21.7s 22.2s 22.0s 21.8s 22.4s Times for minikube (PR 12848) ingress: 36.4s 26.9s 34.5s 27.5s 34.4s docker driver with containerd runtime
Times for minikube ingress: 29.4s 19.9s 32.9s 25.5s 28.4s Times for minikube start: 31.7s 44.8s 43.5s 37.5s 43.9s |
These are the flake rates of all failed tests.
To see the flake rates of all tests by environment, click here. |
These are the flake rates of all failed tests.
To see the flake rates of all tests by environment, click here. |
@medyagh Awesome thanks for this! This is super helpful for my workflows. |
based on a survery comment that asked they wish they could start minikbue without kubernetes
$ mk profile list
list of the procs running inside minikube
closes #12845
TODO it should close #12844