-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the addon manager and dashboard to the iso. #128
Conversation
e35cf39
to
612c0c4
Compare
Output with this running: |
I'll cut the release after this goes in. |
@@ -0,0 +1,23 @@ | |||
apiVersion: v1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file is already present in deploy/static-pods/addon-manager, please copy that one to avoid duplication
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, didn't notice the volume mounting difference between the two.
Then you may move this to deploy/iso/addon-manager.yaml
or deploy/iso/static-pods/addon-manager.yaml
Also, please move deploy/static-pods/addon-manager.yaml
to deploy/docker/static-pods/addon-manager.yaml
Moved the files as requested. |
hostNetwork: true | ||
containers: | ||
- name: kube-addon-manager | ||
image: gcr.io/google-containers/kube-addon-manager:v1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It should be gcr.io/google-containers/kube-addon-manager-amd64:v2
(I made the image with some bugfixes, e.g. allow daemonsets and a kubectl deprecation bugfix...)
Changed the image name. |
LGTM |
No description provided.