Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added restart command after setting crio options #11968

Merged
merged 1 commit into from
Jul 28, 2021

Conversation

kadern0
Copy link
Contributor

@kadern0 kadern0 commented Jul 13, 2021

Fixes #11729

Before:

Screenshot from 2021-07-13 20-37-28

After:

Screenshot from 2021-07-13 20-37-19

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jul 13, 2021
@k8s-ci-robot
Copy link
Contributor

Hi @kadern0. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 13, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: kadern0
To complete the pull request process, please assign ilya-zuyev after the PR has been reviewed.
You can assign the PR to them by writing /assign @ilya-zuyev in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@minikube-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@sharifelgamal
Copy link
Collaborator

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 13, 2021
@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 11968) |
+----------------+----------+---------------------+
| minikube start | 47.7s    | 47.3s               |
| enable ingress | 32.2s    | 31.7s               |
+----------------+----------+---------------------+

Times for minikube start: 49.6s 47.8s 47.6s 47.3s 46.4s
Times for minikube (PR 11968) start: 48.1s 46.1s 46.7s 48.5s 47.1s

Times for minikube ingress: 32.2s 32.4s 31.8s 31.3s 33.3s
Times for minikube (PR 11968) ingress: 31.7s 31.8s 32.2s 31.2s 31.3s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 11968) |
+----------------+----------+---------------------+
| minikube start | 22.8s    | 21.7s               |
| enable ingress | 30.5s    | 27.1s               |
+----------------+----------+---------------------+

Times for minikube ingress: 29.5s 27.0s 34.5s 27.0s 34.5s
Times for minikube (PR 11968) ingress: 27.0s 28.0s 27.5s 26.6s 26.6s

Times for minikube start: 23.5s 22.3s 22.9s 22.8s 22.3s
Times for minikube (PR 11968) start: 21.5s 21.3s 21.9s 21.8s 21.7s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 11968) |
+----------------+----------+---------------------+
| minikube start | 40.6s    | 43.9s               |
| enable ingress |          |                     |
+----------------+----------+---------------------+

Times for minikube (PR 11968) start: 43.2s 43.7s 44.2s 44.1s 44.2s
Times for minikube start: 27.4s 44.3s 43.4s 44.0s 44.1s

@sharifelgamal
Copy link
Collaborator

@afbjorklund what do you think?

@afbjorklund
Copy link
Collaborator

I thought we already did a crio restart below, maybe it was removed since ?

@medyagh medyagh merged commit f20cbf3 into kubernetes:master Jul 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CRI-O systemd unit not picking up /etc/sysconfig/crio.minikube and thus not setting --insecure-registry
7 participants