Allow to set the dashboard proxyfied port #11553

zigarn · 2021-06-01T13:26:54Z

Add a --port option to minikube dashboard, still defaults to 0 to use a random port.

As the value of the port is not accessible elsewhere than from the minikube dashboard output, it can be sometimes useful to set the port in advance to be able to use it.

k8s-ci-robot · 2021-06-01T13:27:02Z

Welcome @zigarn!

It looks like this is your first PR to kubernetes/minikube 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/minikube has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

k8s-ci-robot · 2021-06-01T13:27:02Z

Hi @zigarn. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

minikube-bot · 2021-06-01T13:30:06Z

Can one of the admins verify this patch?

ilya-zuyev

ilyaz@skeletron --- g/minikube ‹dashboard-set-port* ?› » m dashboard --port 77777                                                                                                                                                                       130 ↵
* Enabling dashboard ...
  - Using image kubernetesui/dashboard:v2.1.0
  - Using image kubernetesui/metrics-scraper:v1.0.4
* Verifying dashboard health ...
* Launching proxy ...

X Exiting due to HOST_KUBECTL_PROXY: readByteWithTimeout: EOF
* 
╭──────────────────────────────────────────────────────────────────────────────────╮
│                                                                                  │
│    * If the above advice does not help, please let us know:                      │
│      https://github.com/kubernetes/minikube/issues/new/choose                    │
│                                                                                  │
│    * Please attach the following file to the GitHub issue:                       │
│    * - /tmp/minikube_dashboard_b89fa4de843e548f653e88533f246d7844106df0_0.log    │
│                                                                                  │
╰──────────────────────────────────────────────────────────────────────────────────╯

Could you validate dashboardExposedPort on start? Just to catch the error early and make a better error message

zigarn · 2021-06-03T21:19:53Z

@ilya-zuyev: port range validation added.
But also it would be good to be able to detect an error of kubectl proxy without waiting for it's stdout, no? It would allow to catch any error.

ilya-zuyev · 2021-06-03T21:44:19Z

@ilya-zuyev: port range validation added.
But also it would be good to be able to detect an error of kubectl proxy without waiting for it's stdout, no? It would allow to catch any error.

@zigarn yeah, you're right, would be good to have a better error handling for kubectl proxy. PRs are welcome :)
Thanks for the validation fix!

ilya-zuyev · 2021-06-03T22:43:53Z

/ok-to-test

minikube-pr-bot · 2021-06-03T23:29:42Z

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 11553) |
+----------------+----------+---------------------+
| minikube start | 47.8s    | 46.4s               |
| enable ingress | 39.3s    | 41.8s               |
+----------------+----------+---------------------+

Times for minikube start: 49.5s 47.7s 46.9s 47.3s 47.6s
Times for minikube (PR 11553) start: 46.3s 47.1s 46.1s 45.5s 47.0s

Times for minikube ingress: 39.7s 36.3s 42.7s 35.7s 42.2s
Times for minikube (PR 11553) ingress: 43.2s 42.8s 37.3s 43.2s 42.8s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 11553) |
+----------------+----------+---------------------+
| minikube start | 21.6s    | 21.7s               |
| enable ingress | 35.4s    | 37.4s               |
+----------------+----------+---------------------+

Times for minikube ingress: 35.5s 31.5s 36.0s 33.6s 40.5s
Times for minikube (PR 11553) ingress: 31.5s 35.0s 38.5s 41.5s 40.5s

Times for minikube start: 23.5s 21.2s 20.6s 21.1s 21.8s
Times for minikube (PR 11553) start: 22.8s 22.1s 21.5s 20.9s 21.1s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 11553) |
+----------------+----------+---------------------+
| minikube start | 42.3s    | 45.9s               |
| enable ingress |          |                     |
+----------------+----------+---------------------+

Times for minikube start: 31.8s 47.0s 43.0s 42.6s 47.2s
Times for minikube (PR 11553) start: 48.0s 47.2s 47.2s 43.3s 43.8s

zigarn · 2021-06-10T11:22:38Z

Hi!
CI failures doesn't seem to be caused by this changes.
Anything I need to do to continue the PR validation process?

minikube-bot · 2021-06-21T17:39:58Z

These are the flake rates of all failed tests on Docker_Linux.

Failed Tests	Flake Rate (%)
TestStartStop/group/no-preload/serial/AddonExistsAfterStop	1.37 (chart)
TestStartStop/group/no-preload/serial/SecondStart	1.37 (chart)
TestStartStop/group/no-preload/serial/UserAppExistsAfterStop	1.37 (chart)
TestStartStop/group/no-preload/serial/VerifyKubernetesImages	1.37 (chart)
TestStartStop/group/newest-cni/serial/Pause	2.74 (chart)
TestStartStop/group/no-preload/serial/Pause	6.85 (chart)

minikube-bot · 2021-06-21T17:42:04Z

These are the flake rates of all failed tests on Docker_Linux_containerd.

Failed Tests	Flake Rate (%)
TestPause/serial/Pause	12.00 (chart)
TestPause/serial/VerifyStatus	12.00 (chart)
TestPause/serial/PauseAgain	16.00 (chart)

minikube-pr-bot · 2021-06-21T17:44:01Z

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 11553) |
+----------------+----------+---------------------+
| minikube start | 46.3s    | 46.4s               |
| enable ingress | 35.6s    | 36.3s               |
+----------------+----------+---------------------+

Times for minikube start: 47.0s 45.3s 46.0s 45.7s 47.4s
Times for minikube (PR 11553) start: 46.6s 46.0s 46.0s 46.3s 47.1s

Times for minikube ingress: 35.2s 35.7s 35.2s 37.8s 34.3s
Times for minikube (PR 11553) ingress: 35.2s 35.3s 42.2s 33.7s 35.2s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 11553) |
+----------------+----------+---------------------+
| minikube start | 21.8s    | 21.7s               |
| enable ingress | 36.5s    | 33.1s               |
+----------------+----------+---------------------+

Times for minikube (PR 11553) ingress: 30.6s 33.5s 35.0s 32.5s 34.0s
Times for minikube ingress: 34.5s 37.4s 35.0s 36.9s 38.5s

Times for minikube start: 22.2s 22.1s 21.9s 21.9s 21.0s
Times for minikube (PR 11553) start: 22.6s 22.0s 21.2s 21.4s 21.3s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 11553) |
+----------------+----------+---------------------+
| minikube start | 46.2s    | 43.9s               |
| enable ingress |          |                     |
+----------------+----------+---------------------+

Times for minikube start: 45.8s 46.7s 43.6s 47.8s 47.1s
Times for minikube (PR 11553) start: 42.7s 42.9s 47.0s 43.1s 43.8s

minikube-bot · 2021-06-21T17:55:45Z

These are the flake rates of all failed tests on KVM_Linux_containerd.

Failed Tests	Flake Rate (%)
TestErrorSpam/setup	100.00 (chart)

zigarn · 2021-06-23T07:24:55Z

/assign @spowelljr

minikube-pr-bot · 2021-06-23T08:15:01Z

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 11553) |
+----------------+----------+---------------------+
| minikube start | 47.7s    | 48.4s               |
| enable ingress | 34.9s    | 34.4s               |
+----------------+----------+---------------------+

Times for minikube start: 48.6s 47.9s 47.8s 47.1s 47.1s
Times for minikube (PR 11553) start: 47.8s 46.8s 47.3s 53.5s 46.8s

Times for minikube ingress: 35.3s 36.2s 34.8s 34.3s 34.2s
Times for minikube (PR 11553) ingress: 33.7s 34.7s 35.7s 32.8s 34.8s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 11553) |
+----------------+----------+---------------------+
| minikube start | 21.8s    | 21.5s               |
| enable ingress | 43.5s    | 32.7s               |
+----------------+----------+---------------------+

Times for minikube ingress: 29.0s 91.6s 28.0s 36.5s 32.5s
Times for minikube (PR 11553) ingress: 36.5s 28.5s 37.5s 29.0s 32.0s

Times for minikube start: 23.1s 21.5s 21.1s 21.5s 21.9s
Times for minikube (PR 11553) start: 22.0s 22.1s 21.0s 21.4s 21.0s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 11553) |
+----------------+----------+---------------------+
| minikube start | 40.6s    | 44.8s               |
| enable ingress |          |                     |
+----------------+----------+---------------------+

Times for minikube start: 31.5s 42.8s 43.2s 41.7s 43.8s
Times for minikube (PR 11553) start: 43.4s 46.4s 47.0s 44.5s 42.9s

minikube-bot · 2021-06-23T08:55:25Z

These are the flake rates of all failed tests on KVM_Linux_containerd.

Failed Tests	Flake Rate (%)
TestAddons/parallel/Olm	4.65 (chart)

spowelljr · 2021-07-02T21:19:37Z

@zigarn Sorry for the delay, just tested it and it works great!
The only thing I'd like to see added is:

Add your port flag to the start args for the Dashboard test: https://github.com/kubernetes/minikube/blob/master/test/integration/functional_test.go#L818
And whatever port value you choose, add it to the regex that makes sure the URL is output: https://github.com/kubernetes/minikube/blob/master/test/integration/functional_test.go#L857

Once that's added I'd be happy to merge this!

minikube-pr-bot · 2021-07-03T15:12:04Z

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 11553) |
+----------------+----------+---------------------+
| minikube start | 47.5s    | 48.1s               |
| enable ingress | 35.4s    | 36.8s               |
+----------------+----------+---------------------+

Times for minikube start: 47.8s 48.9s 47.5s 47.4s 46.1s
Times for minikube (PR 11553) start: 46.8s 50.9s 47.0s 49.3s 46.7s

Times for minikube ingress: 37.3s 35.2s 34.8s 33.7s 35.8s
Times for minikube (PR 11553) ingress: 34.2s 36.7s 42.2s 34.3s 36.7s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 11553) |
+----------------+----------+---------------------+
| minikube start | 21.6s    | 21.2s               |
| enable ingress | 36.1s    | 35.1s               |
+----------------+----------+---------------------+

Times for minikube start: 23.1s 21.6s 21.0s 21.2s 21.5s
Times for minikube (PR 11553) start: 21.2s 21.5s 21.3s 21.3s 20.8s

Times for minikube ingress: 31.0s 37.5s 33.5s 40.5s 38.0s
Times for minikube (PR 11553) ingress: 37.4s 34.0s 34.0s 33.4s 36.5s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 11553) |
+----------------+----------+---------------------+
| minikube start | 41.6s    | 43.0s               |
| enable ingress |          |                     |
+----------------+----------+---------------------+

Times for minikube start: 31.0s 43.5s 47.2s 43.2s 43.2s
Times for minikube (PR 11553) start: 42.7s 43.3s 43.1s 42.9s 43.1s

k8s-ci-robot · 2021-07-12T16:53:32Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: spowelljr, zigarn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [spowelljr]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot added the cncf-cla: yes label Jun 1, 2021

k8s-ci-robot added the needs-ok-to-test label Jun 1, 2021

k8s-ci-robot requested review from RA489 and tstromberg June 1, 2021 13:27

k8s-ci-robot added the size/S label Jun 1, 2021

ilya-zuyev reviewed Jun 3, 2021

View reviewed changes

k8s-ci-robot added ok-to-test and removed needs-ok-to-test labels Jun 3, 2021

k8s-ci-robot added needs-rebase and removed needs-rebase labels Jun 23, 2021

k8s-ci-robot assigned spowelljr Jun 23, 2021

zigarn requested a review from ilya-zuyev June 23, 2021 07:26

spowelljr removed their assignment Jul 2, 2021

Allow to set the dashboard proxyfied port

f76b079

zigarn and others added 2 commits July 3, 2021 15:59

Add dashboard port validation

e63b223

Add dashboard port option in corresponding functional test

97c7a1e

spowelljr approved these changes Jul 12, 2021

View reviewed changes

spowelljr merged commit 961bbbe into kubernetes:master Jul 12, 2021

k8s-ci-robot added the approved label Jul 12, 2021

This was referenced Sep 2, 2021

docs: Minikube dashboard remove deprecated port parameter #12387

Closed

Make website have versions matching releases #12391

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Allow to set the dashboard proxyfied port #11553

Allow to set the dashboard proxyfied port #11553

zigarn commented Jun 1, 2021 •

edited

Loading

k8s-ci-robot commented Jun 1, 2021

k8s-ci-robot commented Jun 1, 2021

minikube-bot commented Jun 1, 2021

ilya-zuyev left a comment •

edited

Loading

zigarn commented Jun 3, 2021

ilya-zuyev commented Jun 3, 2021

ilya-zuyev commented Jun 3, 2021

minikube-pr-bot commented Jun 3, 2021

zigarn commented Jun 10, 2021

minikube-bot commented Jun 21, 2021

minikube-bot commented Jun 21, 2021

minikube-pr-bot commented Jun 21, 2021

minikube-bot commented Jun 21, 2021

zigarn commented Jun 23, 2021

minikube-pr-bot commented Jun 23, 2021

minikube-bot commented Jun 23, 2021

spowelljr commented Jul 2, 2021

minikube-pr-bot commented Jul 3, 2021

k8s-ci-robot commented Jul 12, 2021

Allow to set the dashboard proxyfied port #11553

Allow to set the dashboard proxyfied port #11553

Conversation

zigarn commented Jun 1, 2021 • edited Loading

k8s-ci-robot commented Jun 1, 2021

k8s-ci-robot commented Jun 1, 2021

minikube-bot commented Jun 1, 2021

ilya-zuyev left a comment • edited Loading

Choose a reason for hiding this comment

zigarn commented Jun 3, 2021

ilya-zuyev commented Jun 3, 2021

ilya-zuyev commented Jun 3, 2021

minikube-pr-bot commented Jun 3, 2021

zigarn commented Jun 10, 2021

minikube-bot commented Jun 21, 2021

minikube-bot commented Jun 21, 2021

minikube-pr-bot commented Jun 21, 2021

minikube-bot commented Jun 21, 2021

zigarn commented Jun 23, 2021

minikube-pr-bot commented Jun 23, 2021

minikube-bot commented Jun 23, 2021

spowelljr commented Jul 2, 2021

minikube-pr-bot commented Jul 3, 2021

k8s-ci-robot commented Jul 12, 2021

zigarn commented Jun 1, 2021 •

edited

Loading

ilya-zuyev left a comment •

edited

Loading