-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new command "image pull: allow to load remote images directly without cache #11127
Conversation
@spowelljr : Would avoid having to save + scp + load the image help anything, with your benchmarks ? minikube image load image
vs minikube image load image --pull
|
@afbjorklund would this be only useful for publicly available images ? |
You would have to run a registry somewhere, but it doesn't have to use docker hub or any other publicly available one. The main difference is if you plan to do it more than once (e.g. for another cluster, later on). Then you might want to cache. It's still a bit of a premature optimization, you might just deploy and let Kubernetes decide when it needs to pull things...
|
If we want to optimize for startup time, then the best option would be to not load the entire image ahead-of-time. Instead we should run a local registry, and optimize the required kubernetes images for chunk streaming:
That would allow the cluster to start up as quickly as posssible, and pull the rest of the image when it is needed. https://github.com/containerd/stargz-snapshotter/blob/master/docs/overview.md |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: afbjorklund, medyagh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
When looking at the benchmarks, there seems to be a need to pull images without too much intermediate layers...
This bypasses the local daemon and the file cache, and asks the container runtime to pull directly from the registry.
Basically the same as:
minikube ssh -- sudo crictl pull image