WIP: Rename None driver to Native and replace all references #10579

sadlil · 2021-02-23T12:19:10Z

k8s-ci-robot · 2021-02-23T12:19:18Z

Hi @sadlil. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot · 2021-02-23T12:19:20Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: sadlil
To complete the pull request process, please assign priyawadhwa after the PR has been reviewed.
You can assign the PR to them by writing /assign @priyawadhwa in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

minikube-bot · 2021-02-23T12:21:03Z

Can one of the admins verify this patch?

medyagh

can u plz verify, starting a cluster with minikube 1.17.1

minkube start --driver=none

and then stop it
and then start the same cluster with your PR
and ensure it still backward campatible ?

medyagh · 2021-02-23T17:59:44Z

pkg/minikube/driver/driver.go

@@ -142,15 +142,15 @@ func IsMock(name string) bool {

 // IsVM checks if the driver is a VM
 func IsVM(name string) bool {
-	if IsKIC(name) || BareMetal(name) {
+	if IsKIC(name) || IsNative(name) {


this should have stayed BareMetal (because it includes Mokc)

medyagh

all instances of Baremetal should stay same since they include Mock

medyagh · 2021-02-23T18:01:59Z

pkg/minikube/machine/client.go

@@ -156,7 +156,7 @@ func CommandRunner(h *host.Host) (command.Runner, error) {
 	if h.DriverName == driver.Mock {
 		return &command.FakeCommandRunner{}, nil
 	}
-	if driver.BareMetal(h.Driver.DriverName()) {
+	if driver.IsNative(h.Driver.DriverName()) {


all instances of Baremetal should stay same since they include Mock

medyagh · 2021-02-23T18:02:05Z

pkg/minikube/machine/client.go

@@ -220,7 +220,7 @@ func (api *LocalClient) Create(h *host.Host) error {
 		{
 			"waiting",
 			func() error {
-				if driver.BareMetal(h.Driver.DriverName()) {
+				if driver.IsNative(h.Driver.DriverName()) {


all instances of Baremetal should stay same since they include Mock

medyagh · 2021-02-23T18:02:10Z

pkg/minikube/machine/client.go

@@ -230,7 +230,7 @@ func (api *LocalClient) Create(h *host.Host) error {
 			"provisioning",
 			func() error {
 				// Skippable because we don't reconfigure Docker?
-				if driver.BareMetal(h.Driver.DriverName()) {
+				if driver.IsNative(h.Driver.DriverName()) {


medyagh · 2021-02-23T18:02:18Z

pkg/minikube/machine/fix.go

-	// Avoid reprovisioning "none" driver because provision.Detect requires SSH
-	if !driver.BareMetal(h.Driver.DriverName()) {
+	// Avoid reprovisioning "native" driver because provision.Detect requires SSH
+	if !driver.IsNative(h.Driver.DriverName()) {


k8s-ci-robot · 2021-02-24T19:28:50Z

@sadlil: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

fejta-bot · 2021-05-25T19:58:34Z

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle stale

fejta-bot · 2021-06-24T20:31:04Z

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle rotten

andriyDev · 2021-07-13T20:57:28Z

Hi @sadlil, I'm gonna close this PR since it's been stuck for a while. If you'd like to bring it back, feel free to reopen!

Rename None driver to Native

c5f6730

k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 23, 2021

k8s-ci-robot requested review from ilya-zuyev and priyawadhwa February 23, 2021 12:19

k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Feb 23, 2021

medyagh requested changes Feb 23, 2021

View reviewed changes

sadlil force-pushed the none-to-native branch from a0b8248 to b6dcdd7 Compare February 23, 2021 18:57

sadlil changed the title ~~Rename None driver to Native and replace all references~~ WIP: Rename None driver to Native and replace all references Feb 23, 2021

k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 23, 2021

Check backwords compatibility with older clusters

0019efd

sadlil force-pushed the none-to-native branch from b6dcdd7 to 0019efd Compare February 23, 2021 21:04

k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 24, 2021

medyagh mentioned this pull request Mar 24, 2021

rename "none" driver to "native" #7772

Open

k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 25, 2021

k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jun 24, 2021

andriyDev closed this Jul 13, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

WIP: Rename None driver to Native and replace all references #10579

WIP: Rename None driver to Native and replace all references #10579

sadlil commented Feb 23, 2021

k8s-ci-robot commented Feb 23, 2021

k8s-ci-robot commented Feb 23, 2021

minikube-bot commented Feb 23, 2021

medyagh left a comment

medyagh Feb 23, 2021

medyagh left a comment

medyagh Feb 23, 2021

medyagh Feb 23, 2021

medyagh Feb 23, 2021

medyagh Feb 23, 2021

k8s-ci-robot commented Feb 24, 2021

fejta-bot commented May 25, 2021

fejta-bot commented Jun 24, 2021

andriyDev commented Jul 13, 2021

WIP: Rename None driver to Native and replace all references #10579

WIP: Rename None driver to Native and replace all references #10579

Conversation

sadlil commented Feb 23, 2021

k8s-ci-robot commented Feb 23, 2021

k8s-ci-robot commented Feb 23, 2021

minikube-bot commented Feb 23, 2021

medyagh left a comment

Choose a reason for hiding this comment

medyagh Feb 23, 2021

Choose a reason for hiding this comment

medyagh left a comment

Choose a reason for hiding this comment

medyagh Feb 23, 2021

Choose a reason for hiding this comment

medyagh Feb 23, 2021

Choose a reason for hiding this comment

medyagh Feb 23, 2021

Choose a reason for hiding this comment

medyagh Feb 23, 2021

Choose a reason for hiding this comment

k8s-ci-robot commented Feb 24, 2021

fejta-bot commented May 25, 2021

fejta-bot commented Jun 24, 2021

andriyDev commented Jul 13, 2021