Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bump oldest kubernetes version to v1.14.0, bump default kubernetes version #10531

Merged
merged 1 commit into from
Feb 20, 2021
Merged

bump oldest kubernetes version to v1.14.0, bump default kubernetes version #10531

merged 1 commit into from
Feb 20, 2021

Conversation

medyagh
Copy link
Member

@medyagh medyagh commented Feb 20, 2021 •
edited
Loading

closes #10529

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 20, 2021
@medyagh
Copy link
Member Author

medyagh commented Feb 20, 2021

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Feb 20, 2021
@kubernetes kubernetes deleted a comment from minikube-pr-bot Feb 20, 2021
afbjorklund
afbjorklund approved these changes Feb 20, 2021
View reviewed changes
Copy link
Collaborator

@afbjorklund afbjorklund left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK, but there was a lot going on besides just 1.14.0...

Such as updating modules, or going from 1.20.2 to 1.120.4 ?

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: afbjorklund, medyagh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [afbjorklund,medyagh]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@medyagh medyagh merged commit 2d5ab81 into kubernetes:master Feb 20, 2021
@medyagh
Copy link
Member Author

medyagh commented Feb 20, 2021

Looks OK, but there was a lot going on besides just 1.14.0...

Such as updating modules, or going from 1.20.2 to 1.120.4 ?

yeah it was go mod tidy

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 20, 2021
@medyagh medyagh changed the title bump oldest kubernetes version to v1.14.0 bump oldest kubernetes version to v1.14.0, bump default kubernetes version Feb 20, 2021
@medyagh medyagh deleted the bump_oldest_k8s branch March 2, 2021 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afbjorklund afbjorklund afbjorklund approved these changes

@RA489 RA489 Awaiting requested review from RA489

@sharifelgamal sharifelgamal Awaiting requested review from sharifelgamal

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bump oldest supported kuberntes from v1.13.0 to v1.14.0
3 participants
@medyagh @k8s-ci-robot @afbjorklund