Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve kvm network delete/cleanup #10479

Merged
merged 4 commits into from
Feb 20, 2021

Conversation

prezha
Copy link
Contributor

@prezha prezha commented Feb 14, 2021

this pr should further improve kvm private network delete/cleanup, like situations where the --delete flag leaves minikube-net behind in inactive state after a failed start, or when such minikube-net cannot be reused on subsequent starts

improvement on previous issues:
#9666
#9610
#9049
#8952

also potentially improves / fixes #10040

details:

before: we try to reactivate inactive net and then to destroy it (as inactive net cannot be destroyed)
after: transition states are:

  1. nonexistent => done
  2. repeat/retry:
    • active => destroy => undefine => done
    • inactive => undefine => done

example: #10439 (comment)

if this proves working as expected in practice, we would probably be able to remove the repeat/retry wrapper as not needed


note: i remember that we ask users to provide output of virsh net-list to troubleshoot issues - we should ask for virsh net-list --all instead, as otherwise inactive nets will not be shown; also noting that the command should be run as root user, as regular user will probably not see any nets
i've tried to locate those references in docs (around https://minikube.sigs.k8s.io/docs/drivers/kvm2/) and propose these changes, but couldn't find it :(

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 14, 2021
@k8s-ci-robot
Copy link
Contributor

Hi @prezha. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Feb 14, 2021
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Feb 14, 2021
@minikube-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: medyagh, prezha

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 20, 2021
@medyagh medyagh merged commit 6bf3c23 into kubernetes:master Feb 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

KVM Hook script execution failed: internal error: Child process
4 participants