Avoid warning about the suggested memory size #10187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The recommendation is to use (at least) 2048 MB *for the VM*, which means that you will end up something like 1992 MB total. We should not issue warnings when using the recommended size, so lower the limit to 1900 MB (kubeadm will validate 1700 MB). The reason it is broken is because it uses different values for different drivers, if running a VM or on Bare Metal... There is also no difference anymore between the "usable" and the "recommended", so this will need revisiting later.
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
approved
|
Currently you get annoying warnings, if you create a 2 GiB VM and use the |
tstromberg
approved these changes
Jan 20, 2021
medyagh
approved these changes
Jan 20, 2021
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: afbjorklund, medyagh, tstromberg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The recommendation is to use (at least) 2048 MB for the VM,
which means that you will end up something like 1992 MB total.
We should not issue warnings when using the recommended size,
so lower the limit to 1900 MB (kubeadm will validate 1700 MB).
The reason it is broken is because it uses different values
for different drivers, if running a VM or on Bare Metal...
There is also no difference anymore between the "usable"
and the "recommended", so this will need revisiting later.