Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix update kubernetes version script #9898

Closed
medyagh opened this issue Dec 9, 2020 · 1 comment · Fixed by #9912
Closed

fix update kubernetes version script #9898

medyagh opened this issue Dec 9, 2020 · 1 comment · Fixed by #9912
Assignees
@prezha
Labels
kind/process Process oriented issues, like setting up CI priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.

Comments

@medyagh
Copy link
Member

medyagh commented Dec 9, 2020

1- it wont run if u run it from root folder (have to cd into it)
2- it didnt update to newest version

DefaultKubernetesVersion = "v1.20.0"
NewestKubernetesVersion = "v1.20.0"

I expected v1.20.1-rc.0 for newst

3- it didnt run "make generate-docs"
@medyagh medyagh added kind/bug Categorizes issue or PR as related to a bug. kind/process Process oriented issues, like setting up CI priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. and removed kind/bug Categorizes issue or PR as related to a bug. labels Dec 9, 2020
@prezha
Copy link
Contributor

prezha commented Dec 9, 2020

/assign

@prezha prezha mentioned this issue Dec 10, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@prezha prezha

Labels
kind/process Process oriented issues, like setting up CI priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ci update script: use release tags and add make targets prezha/minikube
2 participants
@medyagh @prezha