Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade to klog v2.4.0 #9596

Closed
prezha opened this issue Nov 2, 2020 · 1 comment · Fixed by #9597
Closed

upgrade to klog v2.4.0 #9596

prezha opened this issue Nov 2, 2020 · 1 comment · Fixed by #9597
Assignees

Comments

@prezha
Copy link
Contributor

prezha commented Nov 2, 2020

we're currently using klog v2.3.0 and there is a known issue with --log_file_max_size minikube/klog option flag not working (being ignored), that was fixed in v2.4.0

Steps to reproduce the issue:

  1. minikube start --log_file='mqb.log' --log_file_max_size=3

result: the log file size will eventually grow over the set limit (3mb in this example)

ref: klog issue #171, pr #172

in addition to fixing this bug, v2.4.0 introduced 2 new things:

  • one_output flag:

If true, only write logs to their native severity level (vs also writing to each lower severity level

  • LogFilter capabilities:

LogFilter is a collection of functions that can filter all logging calls, e.g. for sanitization of arguments and prevent accidental leaking of secrets.

and no other major changes

another interesting reason for upgrading to v2.4.0 is the release comment: Prepare release for Kubernetes v1.20

@prezha
Copy link
Contributor Author

prezha commented Nov 2, 2020

/assign

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant