Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade help text does not include "v" in the version number #8205

Closed
alewis001 opened this issue May 19, 2020 · 4 comments
Closed

Upgrade help text does not include "v" in the version number #8205

alewis001 opened this issue May 19, 2020 · 4 comments
Labels
triage/duplicate Indicates an issue is a duplicate of other open issue.

Comments

@alewis001
Copy link

Steps to reproduce the issue:

  1. Have an existing cluster that is running K8s less than 1.18.2
  2. Start the cluster
  3. Note the Message: Kubernetes 1.18.2 is now available. If you would like to upgrade, specify: --kubernetes-version=1.18.2
    • This message was also duplicated in the console output.
  4. Stop the cluster.
  5. Start the cluster, including the suggested argument: --kubernetes-version=1.18.2
    • Start fails with message: [KUBERNETES_VERSION_MISSING_V] Failed to update cluster updating node: generating kubeadm cfg: parsing Kubernetes version: strconv.ParseUint: parsing "": invalid syntax
  6. Change the command line parameter to --kubernetes-version=v1.18.2 (I.e. v1.18.2, not 1.18.2).
  7. Start succeeds.

Full output of failed command:
mk -p bug start
😄 [bug] minikube v1.10.1 on Darwin 10.15.4
✨ Using the hyperkit driver based on existing profile
🆕 Kubernetes 1.18.2 is now available. If you would like to upgrade, specify: --kubernetes-version=1.18.2
🆕 Kubernetes 1.18.2 is now available. If you would like to upgrade, specify: --kubernetes-version=1.18.2
👍 Starting control plane node bug in cluster bug
💾 Downloading Kubernetes v1.18.0 preload ...
> preloaded-images-k8s-v3-v1.18.0-docker-overlay2-amd64.tar.lz4: 525.45 MiB
🔄 Restarting existing hyperkit VM for "bug" ...
🐳 Preparing Kubernetes v1.18.0 on Docker 19.03.8 ...
🌟 Enabled addons: default-storageclass, ingress, ingress-dns, metrics-server, storage-provisioner
🏄 Done! kubectl is now configured to use "bug"

minikube -p bug start --kubernetes-version=1.18.2
😄 [bug] minikube v1.10.1 on Darwin 10.15.4
✨ Using the hyperkit driver based on existing profile
👍 Starting control plane node bug in cluster bug
🔄 Restarting existing hyperkit VM for "bug" ...
🐳 Preparing Kubernetes v1.18.2 on Docker 19.03.8 ...
❌ Unable to load cached images: loading cached images: stat /Users/alewis/.minikube/cache/images/k8s.gcr.io/kube-proxy_v1.18.2: no such file or directory

❌ [KUBERNETES_VERSION_MISSING_V] Failed to update cluster updating node: generating kubeadm cfg: parsing Kubernetes version: strconv.ParseUint: parsing "": invalid syntax
💡 Suggestion: Check that your --kubernetes-version has a leading 'v'. For example: 'v1.1.14'

@alewis001
Copy link
Author

Apologies, I should have included that I've seen this in minikube 1.10.1, I've not tested older versions.

@afbjorklund
Copy link
Collaborator

afbjorklund commented May 19, 2020

Duplicate of issue #8114. And the suggestion offered should still work, i.e. v1.18.2

Wonder why the upgrade text is output twice ? That sounds like a (different) bug.

@afbjorklund afbjorklund added the triage/duplicate Indicates an issue is a duplicate of other open issue. label May 19, 2020
@alewis001
Copy link
Author

Doh! I promise I searched for a duplicate before raising this one! :)

I'll close this.

@afbjorklund
Copy link
Collaborator

Another amazing feature is four different version number standards in two lines of text.

😄 [bug] minikube v1.10.1 on Darwin 10.15.4
🐳 Preparing Kubernetes v1.18.0 on Docker 19.03.8 ...

Most likely those stupid silent v's should not be shown there either, only for machines.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
triage/duplicate Indicates an issue is a duplicate of other open issue.
Projects
None yet
Development

No branches or pull requests

2 participants