Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

site: get rid of redirect on index page #8097

Open
medyagh opened this issue May 12, 2020 · 5 comments
Open

site: get rid of redirect on index page #8097

medyagh opened this issue May 12, 2020 · 5 comments
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/documentation Categorizes issue or PR as related to documentation. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. priority/backlog Higher priority than priority/awaiting-more-evidence.

Comments

@medyagh
Copy link
Member

medyagh commented May 12, 2020

minikube site. has a redirect on the first page from
https://minikube.sigs.k8s.io/
to
https://minikube.sigs.k8s.io/docs

in site/content/en/_index.html we have this:

<a href="/docs">redirecting to /docs</a>
<script language="javascript">
  window.location.replace("/docs");
</script>

instead of re-direct, it should try to load the /docs
you can use help form hugo site
https://gohugo.io/functions/getpage/

please only take this task if you are fimmilar with Hugo and willing to try it locally
using

make site

and try in your local browser that works

@medyagh medyagh added good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/documentation Categorizes issue or PR as related to documentation. labels May 12, 2020
@prasadkatti
Copy link
Contributor

There is a discussion about this topic on Hugo discourse - https://discourse.gohugo.io/t/i-want-to-redirect-my-homepage-to-a-content-page/16318. I don't see a clear answer on that thread. The recommended approach seems to be .GetPage, but it seems some layout changes will also be needed.

@prasadkatti
Copy link
Contributor

This is a "Good First Issue" only if you are familiar with Hugo.

@afbjorklund
Copy link
Collaborator

Back in the previous century, this was when you would use a HTTP 302

@tstromberg tstromberg removed the good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. label Aug 12, 2020
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 10, 2020
@fejta-bot
Copy link

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Dec 10, 2020
@priyawadhwa priyawadhwa added lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. and removed lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. labels Dec 16, 2020
@spowelljr spowelljr added priority/backlog Higher priority than priority/awaiting-more-evidence. and removed priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. labels Apr 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/documentation Categorizes issue or PR as related to documentation. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. priority/backlog Higher priority than priority/awaiting-more-evidence.
Projects
None yet
Development

No branches or pull requests

8 participants