Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: add doc URL to the addon list table #7731

Closed
medyagh opened this issue Apr 17, 2020 · 9 comments · Fixed by #14123
Closed

feature: add doc URL to the addon list table #7731

medyagh opened this issue Apr 17, 2020 · 9 comments · Fixed by #14123
Assignees
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. kind/documentation Categorizes issue or PR as related to documentation. kind/feature Categorizes issue or PR as related to a new feature. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. priority/backlog Higher priority than priority/awaiting-more-evidence.

Comments

@medyagh
Copy link
Member

medyagh commented Apr 17, 2020

while reviwing this PR:#7603

since the URL will be different based on driver, it would be nice that if we have add the URL of the addon to the list, so they dont have to dig into the documentaiton and pain to find the URL for the regsiry

medmac@~/Desktop/md1 $ ./minikube-darwin-amd64 addons list
|-----------------------------|----------|--------------|
|         ADDON NAME          | PROFILE  |    STATUS    |
|-----------------------------|----------|--------------|
| dashboard                   | minikube | disabled     |
| default-storageclass        | minikube | enabled ✅   |
| efk                         | minikube | disabled     |
| freshpod                    | minikube | disabled     |
| gvisor                      | minikube | disabled     |
| helm-tiller                 | minikube | disabled     |
| ingress                     | minikube | disabled     |
| ingress-dns                 | minikube | disabled     |
| istio                       | minikube | disabled     |
| istio-provisioner           | minikube | disabled     |
| logviewer                   | minikube | disabled     |
| metrics-server              | minikube | disabled     |
| nvidia-driver-installer     | minikube | disabled     |
| nvidia-gpu-device-plugin    | minikube | disabled     |
| registry                    | minikube | enabled ✅   |
| registry-aliases            | minikube | disabled     |
| registry-creds              | minikube | disabled     |
| storage-provisioner         | minikube | enabled ✅   |
| storage-provisioner-gluster | minikube | disabled     |
|-----------------------------|----------|--------------|
@medyagh medyagh added the kind/feature Categorizes issue or PR as related to a new feature. label Apr 17, 2020
@medyagh medyagh added this to the v1.11.0 milestone Apr 17, 2020
@medyagh medyagh added the priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. label Apr 17, 2020
@sharifelgamal sharifelgamal changed the title feature: add addonURL o the addon list table feature: add addonURL to the addon list table May 13, 2020
@medyagh
Copy link
Member Author

medyagh commented May 13, 2020

@alonyb do you still wanna do this ?

@medyagh medyagh modified the milestones: v1.11.0 May28, v.1.12.0 May 13, 2020
@medyagh medyagh removed this from the v.1.12.0-previous candidate (dumpster fire) milestone Jun 1, 2020
@medyagh medyagh added kind/documentation Categorizes issue or PR as related to documentation. priority/backlog Higher priority than priority/awaiting-more-evidence. labels Jun 24, 2020
@medyagh medyagh changed the title feature: add addonURL to the addon list table feature: add doc URL to the addon list table Jun 24, 2020
@medyagh medyagh added the good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. label Jun 24, 2020
@QuanLab QuanLab removed their assignment Jul 16, 2020
@goku321
Copy link

goku321 commented Aug 31, 2020

/assign

@goku321
Copy link

goku321 commented Sep 12, 2020

Hi @medyagh do we need to add this url: https://minikube.sigs.k8s.io/docs/drivers/{DRIVER_NAME} to the addon list table?

@medyagh
Copy link
Member Author

medyagh commented Oct 7, 2020

@goku321 driver docs is not needed, only link to the addon doc if there is one.

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 5, 2021
@fejta-bot
Copy link

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Feb 4, 2021
@priyawadhwa priyawadhwa added lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. and removed lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. labels Feb 10, 2021
@rahulii
Copy link

rahulii commented May 25, 2021

/assign

@rahulii
Copy link

rahulii commented May 25, 2021

do we need to add this url to the table https://minikube.sigs.k8s.io/docs/commands/{addon_name}/
e.g https://minikube.sigs.k8s.io/docs/commands/dashboard/
/cc @medyagh

@spowelljr spowelljr removed the priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. label Oct 6, 2021
@Rabattkarte
Copy link
Contributor

/assign

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. kind/documentation Categorizes issue or PR as related to documentation. kind/feature Categorizes issue or PR as related to a new feature. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. priority/backlog Higher priority than priority/awaiting-more-evidence.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

10 participants