Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kic: ensure multi node containers have correct role label #7661

Closed
medyagh opened this issue Apr 14, 2020 · 2 comments
Closed

kic: ensure multi node containers have correct role label #7661

medyagh opened this issue Apr 14, 2020 · 2 comments
Labels
co/docker-driver Issues related to kubernetes in container co/multinode Issues related to multinode clusters co/podman-driver podman driver issues kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.

Comments

@medyagh
Copy link
Member

medyagh commented Apr 14, 2020 •
edited
Loading

verify that when we are creating containers in multi node, we should apply the correct Role label to the container.

this will be helpful for clean up process in kic
@medyagh medyagh added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. co/docker-driver Issues related to kubernetes in container co/podman-driver podman driver issues labels Apr 14, 2020
@tstromberg
Copy link
Contributor

tstromberg commented Apr 16, 2020 •
edited
Loading

Can you please clarify this issue?

@medyagh medyagh added the priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. label Apr 16, 2020
@medyagh medyagh changed the title kic: ListOwnedContainers filter by control plane kic: ensure multi node containers have correct role label Apr 16, 2020
@medyagh medyagh added this to the v1.11.0 milestone Apr 16, 2020
@sharifelgamal sharifelgamal added the co/multinode Issues related to multinode clusters label Apr 16, 2020
@sharifelgamal sharifelgamal mentioned this issue Apr 16, 2020
Open
13 tasks
@sharifelgamal sharifelgamal modified the milestones: v1.11.0 May28, v.1.12.0 May 13, 2020
@medyagh medyagh removed this from the v.1.12.0-previous candidate (dumpster fire) milestone Jun 1, 2020
@medyagh
Copy link
Member Author

medyagh commented Jun 23, 2020

this is nice to have but not needed

@medyagh medyagh closed this as completed Jun 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
co/docker-driver Issues related to kubernetes in container co/multinode Issues related to multinode clusters co/podman-driver podman driver issues kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@tstromberg @medyagh @sharifelgamal