Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docker driver, start again always needs a reset why ? #7432

Closed
medyagh opened this issue Apr 5, 2020 · 2 comments
Closed

docker driver, start again always needs a reset why ? #7432

medyagh opened this issue Apr 5, 2020 · 2 comments
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.

Comments

@medyagh
Copy link
Member

medyagh commented Apr 5, 2020

Unlike VM , start after start in docker invokes preparing kubernetes

right after starting a docker driver
when we start again (I added debugging statement)

we need to figure out why api server is in Sate Error when we do start again.

$ make && ./out/minikube start --vm-driver=docker
😄  minikube v1.9.2 on Darwin 10.13.6
✨  Using the docker driver based on existing profile
👍  Starting control plane node m01 in cluster minikube
🚜  Pulling base image ...
🏃  Updating the running docker "minikube" container ...
🐳  Preparing Kubernetes v1.18.0 on Docker 19.03.2 ...
    ▪ kubeadm.pod-network-cidr=10.244.0.0/16
needs reset: apiserver in state Error🌟  Enabling addons: default-storageclass, storage-provisioner
🏄  Done! kubectl is now configured to use "minikube"

I belive the root cause is that that Provosion is restarting docker that kills api server
code from fix.go

	h, err = recreateIfNeeded(api, cc, n, h)
	if err != nil {
		return h, err
	}

	// Avoid reprovisioning "none" driver because provision.Detect requires SSH
	if !driver.BareMetal(h.Driver.DriverName()) {
		e := engineOptions(cc)
		h.HostOptions.EngineOptions.Env = e.Env
		err = provisionDockerMachine(h)
		if err != nil {
			return h, errors.Wrap(err, "provision")
		}
	}

	if driver.IsMock(h.DriverName) {
		return h, nil
	}

	if err := postStartSetup(h, cc); err != nil {
		return h, errors.Wrap(err, "post-start")
	}

@medyagh medyagh added the priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. label Apr 5, 2020
@medyagh
Copy link
Member Author

medyagh commented Apr 5, 2020

I believe this is the root cause --> #7433

@priyawadhwa priyawadhwa added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Apr 8, 2020
@medyagh medyagh closed this as completed May 9, 2020
@medyagh
Copy link
Member Author

medyagh commented May 9, 2020

I think this mystrie was due to the IP change

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants