Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

start: Add flag to signify that it's OK to delete broken clusters #7233

Closed
tstromberg opened this issue Mar 25, 2020 · 3 comments · Fixed by #7345
Closed

start: Add flag to signify that it's OK to delete broken clusters #7233

tstromberg opened this issue Mar 25, 2020 · 3 comments · Fixed by #7345
Labels
priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. ux/embedded Embedded UX blockers
Milestone
v1.10.0

Comments

@tstromberg
Copy link
Contributor

Exact flag name TBD, but for embedded use cases, it isn't as important to preserve user data as it is to guarantee that a cluster is created somehow.

We tried this as a default in v1.5, but users did not like the behavior.
@tstromberg tstromberg added priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. ux/embedded Embedded UX blockers labels Mar 25, 2020
@tstromberg tstromberg mentioned this issue Mar 25, 2020
Closed
@etanshaul
Copy link

do you think it would make sense to also retry the command once (e.g minikube start -p []) after deleting the cluster?

@tstromberg tstromberg changed the title Add --delete-broken flag to signify that it's OK to delete broken clusters Add flag to signify that it's OK to delete broken clusters Mar 31, 2020
@tstromberg tstromberg added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. labels Mar 31, 2020
@tstromberg tstromberg changed the title Add flag to signify that it's OK to delete broken clusters start: Add flag to signify that it's OK to delete broken clusters Mar 31, 2020
@tstromberg
Copy link
Contributor Author

@etanshaul - At least In v1.9, we retry cluster creation so long as the cluster was created by this session. We should ensure that this behavior is preserved with this new flag.

@tstromberg
Copy link
Contributor Author

tstromberg commented Mar 31, 2020 •
edited
Loading

To clarify: the intended behavior here is: If startup fails and flag is set:

  • Delete the cluster (no data worth saving)
  • Start it again

@sharifelgamal sharifelgamal mentioned this issue Mar 31, 2020
Merged
@tstromberg tstromberg added this to the v1.10.0 milestone Apr 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. ux/embedded Embedded UX blockers
Projects
None yet
Milestone
v1.10.0
Development

Successfully merging a pull request may close this issue.

add delete-on-failure flag sharifelgamal/minikube
2 participants
@tstromberg @etanshaul