Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Progress bar: Transferring cached image #7175

Open
wfhartford opened this issue Mar 23, 2020 · 7 comments
Open

Add Progress bar: Transferring cached image #7175

wfhartford opened this issue Mar 23, 2020 · 7 comments
Labels
cmd/cache Issues with the "cache" command help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. priority/backlog Higher priority than priority/awaiting-more-evidence. sig/ui Categorizes an issue or PR as relevant to SIG UI.

Comments

@wfhartford
Copy link

I've recently started making use of the minikube image cache. When starting minikube, the startup stalls for a very long time at the following:

😄  minikube v1.8.2 on Linuxmint 19.3
✨  Using the kvm2 driver based on user configuration
🔥  Creating kvm2 VM (CPUs=8, Memory=18432MB, Disk=40000MB) ...
🐳  Preparing Kubernetes v1.17.3 on Docker 19.03.6 ...
🚀  Launching Kubernetes ... 
🌟  Enabling addons: default-storageclass, storage-provisioner

The first few times I encountered this, I though something had broken. It would be helpful to indicate to the user that progress is being made.

@priyawadhwa priyawadhwa added cmd/cache Issues with the "cache" command kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. labels Mar 25, 2020
@priyawadhwa
Copy link

Hey @wfhartford -- thanks for opening this issue. Could you provide the output of:

minikube start --alsologtostderr

so that we can see exactly where minikube is stalling? Thanks!

@priyawadhwa priyawadhwa added the kind/support Categorizes issue or PR as a support question. label Mar 25, 2020
@wfhartford
Copy link
Author

Attaching the requested output:
minikube-start-logs.txt

In this log you can see that the time between these two lines is about 5 minutes.

🌟  Enabling addons: default-storageclass, storage-provisioner
⌛  Waiting for cluster to come online ...

Without the stderr logs, there is no clear indication as to what is taking so long. Once we realise that this delay is required to pre-load the docker image cache, the duration is completely understandable. I'm using quite a few large images.

To be clear, this issue is not a request to make that copy faster, simply to provide some indication to the user as to what is happening in the 5 minutes (or more or less depending on the contents of the cache) that there is no activity on the console.

@tstromberg tstromberg added kind/feature Categorizes issue or PR as related to a new feature. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. and removed kind/support Categorizes issue or PR as a support question. labels Apr 16, 2020
@priyawadhwa
Copy link

@wfhartford thanks for clarifying!

I feel like the simple fix is just to add additional logging, something like:

   Transferring cached image busybox ...
   Transferring cached image ubuntu ....

and a slightly more advanced fix could be a progress bar.

If anyone is interested in adding either of these, please feel free to take on this issue by commenting /assign.

@priyawadhwa priyawadhwa added the help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. label Apr 22, 2020
@wfhartford
Copy link
Author

The simple logging solution could probably be easily enhanced by including image numbers like this:

Transferring cached image busybox (1/5) ...
Transferring cached image ubuntu (2/5) ....

@medyagh
Copy link
Member

medyagh commented May 13, 2020

that is a very good suggestion @wfhartford
I would be happy review any PR that adds a progress bar or something like that to the UI !

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 11, 2020
@medyagh medyagh changed the title Request: Add startup status when transferring cached images Add Progress bar: Transferring cached image Aug 12, 2020
@medyagh medyagh added the sig/ui Categorizes an issue or PR as relevant to SIG UI. label Aug 12, 2020
@fejta-bot
Copy link

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Sep 11, 2020
@tstromberg tstromberg added lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. and removed kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. labels Sep 23, 2020
@priyawadhwa priyawadhwa added priority/backlog Higher priority than priority/awaiting-more-evidence. and removed priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. labels Jan 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cmd/cache Issues with the "cache" command help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. priority/backlog Higher priority than priority/awaiting-more-evidence. sig/ui Categorizes an issue or PR as relevant to SIG UI.
Projects
None yet
Development

No branches or pull requests

6 participants