-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
--host-only-cidr: invalid CIDR address: '192.168.99.1/24' #7063
Comments
Can you please share the entire The example |
It seems like the quotes ended up inside the actual configuration, somehow. package main
import "net"
import "fmt"
func main() {
hostOnlyCIDR := "'192.168.99.1/24'"
ip, network, err := net.ParseCIDR(hostOnlyCIDR)
if err != nil {
panic(fmt.Sprintf("%v", err))
}
fmt.Printf("ip: %v, network: %v\n", ip, network)
} panic: invalid CIDR address: '192.168.99.1/24' With just the regular quotes (i.e. not the embedded single quotes), it is fine. ip: 192.168.99.1, network: 192.168.99.0/24 |
Unless I am missing something, that is the default option anyway ?
|
I usually used to run
I don't remember the details why I actually started using the host-only-cidr switch - IIRC back when I started using minikube (around v1.4.0) the minikube VM sometimes ended up using the wrong host-only-network. |
As @afbjorklund commented, I think the only thing to do here is to trim the address of quotes & validate that it is valid. If invalid, return an error message.
this code would probably live in a helper function that would be called here:
If anyone is interested in taking this on, feel free to take this issue by commenting |
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
Stale issues rot after 30d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
/assign |
/remove-lifecycle frozen |
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-contributor-experience at kubernetes/community. |
Stale issues rot after 30d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-contributor-experience at kubernetes/community. |
@Aut0R3V are you still working on this ? |
Hi, I was trying to replicate this issue. The value of fmt.Println(viper.GetString("host-only-cidr")) that I am getting does not have the single quotes on my output hen running the command |
yes with the latest minikube I am also able to get the cluster started as expected |
With my ancient minikube version (1.4.0), I had been using the option
which now gives me
with both 1.8.1 and 1.8.2.
I used the option to make sure that the minikube VM gets attached to the right host-only network. It now seemed to work fine without it, so this might be no longer needed, but still...
Regards
J
The text was updated successfully, but these errors were encountered: