Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

profile list returns non-zero if a cluster is not running #6743

Open
medyagh opened this issue Feb 22, 2020 · 4 comments
Open

profile list returns non-zero if a cluster is not running #6743

medyagh opened this issue Feb 22, 2020 · 4 comments
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/bug Categorizes issue or PR as related to a bug. kind/feature Categorizes issue or PR as related to a new feature. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. priority/backlog Higher priority than priority/awaiting-more-evidence.

Comments

@medyagh
Copy link
Member

medyagh commented Feb 22, 2020

when I was looking at this intergeration test that failed because profile list says one of the clusters is not running yet...

https://storage.googleapis.com/minikube-builds/logs/6717/e653589/Docker_Linux.html#fail_TestFunctional%2fparallel%2fProfileCmd%2fprofile_list

and also one of the users who was using minikube in a test script,... made me think.

When are the resonable times to exit none-zero for profile list ?

currently we exit non-zero for the following:

  • If there is no profile .
  • if there are a few profiles are one of them has error to give status running.
@medyagh medyagh added the triage/discuss Items for discussion label Feb 22, 2020
@priyawadhwa priyawadhwa added the kind/design Categorizes issue or PR as related to design. label Feb 26, 2020
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 26, 2020
@tstromberg tstromberg removed the triage/discuss Items for discussion label Jun 24, 2020
@medyagh medyagh added priority/backlog Higher priority than priority/awaiting-more-evidence. triage/discuss Items for discussion labels Jul 7, 2020
@tstromberg
Copy link
Contributor

I think we should emulate the output of:

kubectl po -A
docker ps

These two commands do not error if one of the pods/containers is not running.

@tstromberg tstromberg changed the title discuss: should profile list return non-zero if cluster status is not running ? profile list returns non-zero if a cluster is not running Jul 22, 2020
@tstromberg tstromberg added the kind/bug Categorizes issue or PR as related to a bug. label Jul 22, 2020
@priyawadhwa priyawadhwa removed the triage/discuss Items for discussion label Jul 22, 2020
@fejta-bot
Copy link

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Aug 21, 2020
@sharifelgamal sharifelgamal added lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. and removed lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. priority/backlog Higher priority than priority/awaiting-more-evidence. labels Aug 26, 2020
@priyawadhwa priyawadhwa added help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. priority/backlog Higher priority than priority/awaiting-more-evidence. and removed priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. labels Dec 28, 2020
@MadhavJivrajani
Copy link
Contributor

/remove-kind design
/kind feature
kind/design is migrated to kind/feature, see kubernetes/community#6144 for more details

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. and removed kind/design Categorizes issue or PR as related to design. labels Oct 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/bug Categorizes issue or PR as related to a bug. kind/feature Categorizes issue or PR as related to a new feature. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. priority/backlog Higher priority than priority/awaiting-more-evidence.
Projects
None yet
Development

No branches or pull requests

7 participants