Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support image secret and docker config.json customization for minikube #6080

Closed
Colstuwjx opened this issue Dec 13, 2019 · 2 comments
Closed
Labels
co/docker-env docker-env issues kind/feature Categorizes issue or PR as related to a new feature. priority/backlog Higher priority than priority/awaiting-more-evidence.

Comments

@Colstuwjx
Copy link

The exact command to reproduce the issue:
minikube start, and when I want to create k8s deployment resource with thirdparty image registry, I need to create image secret inside k8s and create .docker/config.json inside minikube machine.

Is there anyway to customize this, and avoid to manual operation for creating image secret and config.json.

Thanks.

The full output of the command that failed:


None

The output of the minikube logs command:

None

The operating system version: MacOS Mojave 10.14.6

@tstromberg
Copy link
Contributor

tstromberg commented Dec 16, 2019

https://minikube.sigs.k8s.io/docs/tasks/sync/ might be helpful here - it provides a way to overwrite files within the minikube VM every time you start the cluster. You could for instance stick custom credential files and a custom docker config there. If you go this route, I'd love to see a tutorial written and added to https://minikube.sigs.k8s.io/docs/tutorials/ for this.

As far as a specific feature goes, I'd be open to any proposals you might have.

@tstromberg tstromberg added kind/documentation Categorizes issue or PR as related to documentation. co/docker-env docker-env issues kind/feature Categorizes issue or PR as related to a new feature. priority/backlog Higher priority than priority/awaiting-more-evidence. and removed kind/documentation Categorizes issue or PR as related to documentation. labels Dec 16, 2019
@Colstuwjx
Copy link
Author

I have tried sync feature, it works well!

But k8s still prompt me that I need to create the image secret by some pull errors. I think leave this job to minikube is hard to implement, since we need one image secret for each namespace.

As a result, I'd like to use the sync feature to sync docker config, and just create the image secret by manually or by some PaaS platform.

Thanks for your reply, minikube is awesome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
co/docker-env docker-env issues kind/feature Categorizes issue or PR as related to a new feature. priority/backlog Higher priority than priority/awaiting-more-evidence.
Projects
None yet
Development

No branches or pull requests

2 participants