Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

release_update_brew: access_token: unbound variable #5779

Closed
tstromberg opened this issue Oct 30, 2019 · 4 comments · Fixed by #6552
Closed

release_update_brew: access_token: unbound variable #5779

tstromberg opened this issue Oct 30, 2019 · 4 comments · Fixed by #6552
Assignees
@tstromberg
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/process Process oriented issues, like setting up CI packaging/brew macOS (brew) packaging issues priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.

Comments

@tstromberg
Copy link
Contributor

tstromberg commented Oct 30, 2019 •
edited
Loading

minikube migrated from cask to brew, but the automation has not been updated to use bump-formula-pr.rb to trigger updates: https://github.com/Linuxbrew/brew/blob/master/docs/How-To-Open-a-Homebrew-Pull-Request.md

Here is where the automation should go:

minikube/hack/jenkins/release_update_brew.sh

Line 43 in 9be4046

echo "Sorry, this script has not yet been updated to support non-cask updates"

@tstromberg tstromberg added this to the v1.6.0 milestone Oct 30, 2019
@tstromberg tstromberg mentioned this issue Oct 31, 2019
Merged
@afbjorklund afbjorklund added the packaging/brew macOS (brew) packaging issues label Nov 3, 2019
@medyagh medyagh added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. kind/process Process oriented issues, like setting up CI labels Nov 4, 2019
@tstromberg tstromberg modified the milestones: v1.6.0, v1.7.0-candidate Dec 9, 2019
@tstromberg tstromberg removed this from the v1.7.0 milestone Jan 30, 2020
@tstromberg tstromberg self-assigned this Jan 31, 2020
@tstromberg tstromberg added the help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. label Feb 5, 2020
@tstromberg tstromberg mentioned this issue Feb 7, 2020
Merged
@tstromberg tstromberg reopened this Feb 8, 2020
@tstromberg
Copy link
Contributor Author

Failed due to:

16:27:11 hack/jenkins/release_update_brew.sh: line 42: access_token: unbound variable
16:27:11 Build step 'Execute shell' marked build as failure

@Doqnach
Copy link

Doqnach commented Feb 10, 2020

Just now was able to upgrade minikube to 1.7.2 using brew upgrade minikube

@tstromberg tstromberg changed the title Update release automation to use brew instead of cask release_update_brew: access_token: unbound variable Feb 19, 2020
@tstromberg
Copy link
Contributor Author

tstromberg commented Feb 19, 2020 •
edited
Loading

Updating title to reflect current state.

The script assumes that the GitHub token is exported by Jenkins into the environment as 'access_token'. When I looked into it, it seemed that Jenkins was configured properly, but I am not an expert in it.

@medyagh
Copy link
Member

medyagh commented Mar 13, 2020

this was fixed

@medyagh medyagh closed this as completed Mar 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tstromberg tstromberg

Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/process Process oriented issues, like setting up CI packaging/brew macOS (brew) packaging issues priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update script to use bump-formula-pr tstromberg/minikube
4 participants
@tstromberg @medyagh @afbjorklund @Doqnach