FailFast if hyperkit is not installed. #5478

medyagh · 2019-09-26T21:35:38Z

on a fresh macbook I had the following errors (not installed hyperkit)
minikube is trying to Retry to see if there would be an executable. while we should fail fast and tell user without must noise, to install hyperkit.

$ minikube start --vm-driver=hyperkit
😄  minikube v1.4.0 on Darwin 10.14.6
💾  Downloading driver docker-machine-driver-hyperkit:
    > docker-machine-driver-hyperkit.sha256: 65 B / 65 B [---] 100.00% ? p/s 0s
    > docker-machine-driver-hyperkit: 28.85 MiB / 28.85 MiB  100.00% 13.73 MiB 
🔑  The 'hyperkit' driver requires elevated permissions. The following commands will be executed:

    $ sudo chown root:wheel /Users/medya/.minikube/bin/docker-machine-driver-hyperkit 
    $ sudo chmod u+s /Users/medya/.minikube/bin/docker-machine-driver-hyperkit 


Password: 
Password: 
💿  Downloading VM boot image ...
    > minikube-v1.4.0.iso.sha256: 65 B / 65 B [--------------] 100.00% ? p/s 0s
    > minikube-v1.4.0.iso: 135.73 MiB / 135.73 MiB [-] 100.00% 19.20 MiB p/s 7s
🔥  Creating hyperkit VM (CPUs=2, Memory=2000MB, Disk=20000MB) ...
🔄  Retriable failure: create: Error creating machine: Error in driver during machine creation: new-ing Hyperkit: Could not find hyperkit executable
🔥  Deleting "minikube" in hyperkit ...
E0926 14:32:58.273210   25064 main.go:100] libmachine: (minikube) Error reading pid file: open /Users/medya/.minikube/machines/minikube/hyperkit.json: no such file or directory
🔥  Creating hyperkit VM (CPUs=2, Memory=2000MB, Disk=20000MB) ...
🔄  Retriable failure: create: Error creating machine: Error in driver during machine creation: new-ing Hyperkit: Could not find hyperkit executable
🔥  Deleting "minikube" in hyperkit ...
E0926 14:33:06.640044   25064 main.go:100] libmachine: (minikube) Error reading pid file: open /Users/medya/.minikube/machines/minikube/hyperkit.json: no such file or directory
🔥  Creating hyperkit VM (CPUs=2, Memory=2000MB, Disk=20000MB) ...
🔄  Retriable failure: create: Error creating machine: Error in driver during machine creation: new-ing Hyperkit: Could not find hyperkit executable
🔥  Deleting "minikube" in hyperkit ...
E0926 14:33:15.004596   25064 main.go:100] libmachine: (minikube) Error reading pid file: open /Users/medya/.minikube/machines/minikube/hyperkit.json: no such file or directory
🔥  Creating hyperkit VM (CPUs=2, Memory=2000MB, Disk=20000MB) ...
🔄  Retriable failure: create: Error creating machine: Error in driver during machine creation: new-ing Hyperkit: Could not find hyperkit executable
🔥  Deleting "minikube" in hyperkit ...
E0926 14:33:25.064406   25064 main.go:100] libmachine: (minikube) Error reading pid file: open /Users/medya/.minikube/machines/minikube/hyperkit.json: no such file or directory

💣  Unable to start VM: create: Error creating machine: Error in driver during machine creation: new-ing Hyperkit: Could not find hyperkit executable

😿  Sorry that minikube crashed. If this was unexpected, we would love to hear from you:
👉  https://github.com/kubernetes/minikube/issues/new/choose

we need to detect after the driver-download that the hyperkit is not installed and exit with the links to documentation how to install it.

https://minikube.sigs.k8s.io/docs/start/macos/
or simply say

please install hyperkit using brew
`brew install hyperkit` or alternatively, you may Install HyperKit from GitHub https://github.com/moby/hyperkit

The text was updated successfully, but these errors were encountered:

govargo · 2019-10-31T08:14:14Z

I will work on this.

/assign

govargo · 2019-10-31T11:37:27Z

It seems that minikube outputs Suggestion message brew install hyperkit in v1.5.1.
But the minikube start & minikube delete errors keep happening.
I'll fix this.

And...I'm wondering.
Why minikube downloads docker-machine-driver-hyperkit, when hyperkit binary does not exist.
In my opinion, we can only install hyperkit by brew or make from source.
So Is docker-machine-driver-hyperkit used by what action?

$ minikube start --vm-driver=hyperkit
😄  minikube v1.5.1 on Darwin 10.14.5

⚠️  'hyperkit' driver reported a possible issue: exec: "hyperkit": executable file not found in $PATH
💡  Suggestion: Run 'brew install hyperkit'
📘  Documentation: https://minikube.sigs.k8s.io/docs/reference/drivers/hyperkit/

💾  Downloading driver docker-machine-driver-hyperkit:
    > docker-machine-driver-hyperkit.sha256: 65 B / 65 B [---] 100.00% ? p/s 0s
    > docker-machine-driver-hyperkit: 10.79 MiB / 10.79 MiB  100.00% 4.57 MiB p
🔑  The 'hyperkit' driver requires elevated permissions. The following commands will be executed:

    $ sudo chown root:wheel /Users/k-iso/.minikube/bin/docker-machine-driver-hyperkit
    $ sudo chmod u+s /Users/k-iso/.minikube/bin/docker-machine-driver-hyperkit


Password:
💿  Downloading VM boot image ...
    > minikube-v1.5.1.iso.sha256: 65 B / 65 B [--------------] 100.00% ? p/s 0s
    > minikube-v1.5.1.iso: 143.76 MiB / 143.76 MiB [-] 100.00% 64.66 MiB p/s 3s
🔥  Creating hyperkit VM (CPUs=2, Memory=2000MB, Disk=20000MB) ...
🔄  Retriable failure: create: Error creating machine: Error in driver during machine creation: new-ing Hyperkit: Could not find hyperkit executable
🔥  Deleting "minikube" in hyperkit ...
🔥  Creating hyperkit VM (CPUs=2, Memory=2000MB, Disk=20000MB) ...
🔄  Retriable failure: create: Error creating machine: Error in driver during machine creation: new-ing Hyperkit: Could not find hyperkit executable
🔥  Deleting "minikube" in hyperkit ...
🔥  Creating hyperkit VM (CPUs=2, Memory=2000MB, Disk=20000MB) ...
🔄  Retriable failure: create: Error creating machine: Error in driver during machine creation: new-ing Hyperkit: Could not find hyperkit executable
🔥  Deleting "minikube" in hyperkit ...
🔥  Creating hyperkit VM (CPUs=2, Memory=2000MB, Disk=20000MB) ...
🔄  Retriable failure: create: Error creating machine: Error in driver during machine creation: new-ing Hyperkit: Could not find hyperkit executable
🔥  Deleting "minikube" in hyperkit ...

💣  Unable to start VM: create: Error creating machine: Error in driver during machine creation: new-ing Hyperkit: Could not find hyperkit executable

😿  Sorry that minikube crashed. If this was unexpected, we would love to hear from you:
👉  https://github.com/kubernetes/minikube/issues/new/choose

medyagh · 2019-10-31T15:53:14Z

@govargo we have our own docker-machine-driver-hyperkit that wraps arround the hyperkit driver.

It's confusing to users because they think we are downloading the hyperkit for them.

I agree it's useless to download our driver for hyperkit if the hyperkit itself is not installed. We need to fail fast and provide them instruction to install or it even better if they have brew we could do it for them

medyagh · 2019-10-31T15:55:11Z

@govargo it's yours ! Will be happy to review the PR

govargo · 2019-10-31T17:18:29Z

@medyagh

I agree it's useless to download our driver for hyperkit if the hyperkit itself is not installed. We need to fail fast and provide them instruction to install or it even better if they have brew we could do it for them

Thank you for your comment!
I understand this!

medyagh · 2019-10-31T22:10:53Z

@govargo one request,

we just had an issue that having an older hyperkit driver, caused this issue #5594

it would be great that as part of this PR, on top of checking if hyperkit is installed, we check for the hyperkit version, and if there is an update available or if it is older than a specific verison, warn user about it or ask them if they let us upgrade it for them

govargo · 2019-11-01T02:07:12Z

@medyagh

it would be great that as part of this PR, on top of checking if hyperkit is installed, we check for the hyperkit version, and if there is an update available or if it is older than a specific verison, warn user about it or ask them if they let us upgrade it for them

OK,I see.
I'll add a presence check of hyperkit and version check of it.

tstromberg · 2019-12-16T23:29:04Z

We do this now as of minikube v1.6, unless they specify --vm-driver=hyperkit, at which point we warn I believe.

govargo · 2019-12-17T12:44:49Z

@tstromberg Thank you for sharing. I'll close the PR #5833

tstromberg · 2019-12-17T17:00:44Z

@govargo - #5833 also handles version checking. We don't do anything with versions, so your PR is still valuable.

medyagh added help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. co/hyperkit Hyperkit related issues labels Sep 26, 2019

medyagh changed the title ~~detect early if hyperkit is not installed.~~ FailFast and detect early if hyperkit is not installed. Sep 26, 2019

medyagh added the priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. label Sep 26, 2019

medyagh added this to the v1.5.0 milestone Sep 26, 2019

medyagh changed the title ~~FailFast and detect early if hyperkit is not installed.~~ FailFast if hyperkit is not installed. Sep 26, 2019

tstromberg modified the milestones: v1.5.0, v1.6.0-candidate Oct 14, 2019

tstromberg removed this from the v1.6.0-candidate milestone Oct 21, 2019

k8s-ci-robot assigned govargo Oct 31, 2019

govargo mentioned this issue Nov 3, 2019

FailFast if virtualbox is not installed. #5821

Closed

medyagh added kind/feature Categorizes issue or PR as related to a new feature. and removed help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. labels Nov 4, 2019

govargo mentioned this issue Nov 5, 2019

Add hyperkit version check whether user's hyperkit is newer #5833

Merged

tstromberg added priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. and removed priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. labels Dec 9, 2019

tstromberg closed this as completed Dec 16, 2019

jandubois mentioned this issue Dec 23, 2020

Packaging for macOS rancher-sandbox/rancher-desktop#28

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

FailFast if hyperkit is not installed. #5478

FailFast if hyperkit is not installed. #5478

medyagh commented Sep 26, 2019 •

edited

Loading

govargo commented Oct 31, 2019

govargo commented Oct 31, 2019 •

edited

Loading

medyagh commented Oct 31, 2019 •

edited

Loading

medyagh commented Oct 31, 2019

govargo commented Oct 31, 2019

medyagh commented Oct 31, 2019 •

edited

Loading

govargo commented Nov 1, 2019

tstromberg commented Dec 16, 2019 •

edited

Loading

govargo commented Dec 17, 2019

tstromberg commented Dec 17, 2019 •

edited

Loading

FailFast if hyperkit is not installed. #5478

FailFast if hyperkit is not installed. #5478

Comments

medyagh commented Sep 26, 2019 • edited Loading

govargo commented Oct 31, 2019

govargo commented Oct 31, 2019 • edited Loading

medyagh commented Oct 31, 2019 • edited Loading

medyagh commented Oct 31, 2019

govargo commented Oct 31, 2019

medyagh commented Oct 31, 2019 • edited Loading

govargo commented Nov 1, 2019

tstromberg commented Dec 16, 2019 • edited Loading

govargo commented Dec 17, 2019

tstromberg commented Dec 17, 2019 • edited Loading

medyagh commented Sep 26, 2019 •

edited

Loading

govargo commented Oct 31, 2019 •

edited

Loading

medyagh commented Oct 31, 2019 •

edited

Loading

medyagh commented Oct 31, 2019 •

edited

Loading

tstromberg commented Dec 16, 2019 •

edited

Loading

tstromberg commented Dec 17, 2019 •

edited

Loading