Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add branding to distribution #5105

Closed
afbjorklund opened this issue Aug 16, 2019 · 7 comments
Closed

Add branding to distribution #5105

afbjorklund opened this issue Aug 16, 2019 · 7 comments
Labels
area/guest-vm General configuration issues with the minikube guest VM kind/feature Categorizes issue or PR as related to a new feature. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. priority/backlog Higher priority than priority/awaiting-more-evidence.

Comments

@afbjorklund
Copy link
Collaborator

afbjorklund commented Aug 16, 2019

Currently we ship the distribution with an unmodified /etc/os-release like so:

	( \
		echo "NAME=Buildroot"; \
		echo "VERSION=$(BR2_VERSION_FULL)"; \
		echo "ID=buildroot"; \
		echo "VERSION_ID=$(BR2_VERSION)"; \
		echo "PRETTY_NAME=\"Buildroot $(BR2_VERSION)\"" \
	) >  $(TARGET_DIR)/usr/lib/os-release

But we do our own configuration and modification, to the basic Buildroot system.

The libmachine upstream boot2docker.iso does this, and looks something like:

docker@default:~$ cat /etc/os-release 
NAME=Boot2Docker
VERSION=19.03.1
ID=boot2docker
ID_LIKE=tcl
VERSION_ID=19.03.1
PRETTY_NAME="Boot2Docker 19.03.1 (TCL 10.1)"
ANSI_COLOR="1;34"
HOME_URL="https://github.com/boot2docker/boot2docker"
SUPPORT_URL="https://blog.docker.com/2016/11/introducing-docker-community-directory-docker-community-slack/"
BUG_REPORT_URL="https://github.com/boot2docker/boot2docker/issues"

The original distribution (in our case "buildroot") ends up under "ID_LIKE".

Also the Linux version gets a suffix, to indicate custom kernel configuration.

docker@default:~$ uname -r
4.14.134-boot2docker

We could do our own branding here, and advertise minikube and ISO version ?

NAME=minikube
VERSION=1.3.0
ID=minikube
ID_LIKE=buildroot
VERSION_ID=1.3.0
PRETTY_NAME="minikube 1.3.0 (Buildroot 2018.05.3)"
HOME_URL="https://github.com/kubernetes/minikube"

https://www.freedesktop.org/software/systemd/man/os-release.html

@afbjorklund afbjorklund added area/guest-vm General configuration issues with the minikube guest VM triage/discuss Items for discussion labels Aug 16, 2019
@tstromberg tstromberg removed the triage/discuss Items for discussion label Sep 30, 2019
@medyagh medyagh added priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. kind/feature Categorizes issue or PR as related to a new feature. labels Nov 6, 2019
@priyawadhwa priyawadhwa added good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. labels Dec 16, 2019
@priyawadhwa
Copy link

If anybody is interested in working on this issue, we would love some help. Feel free to assign yourself by commenting /assign and I'll be happy to review any PRs.

@afbjorklund
Copy link
Collaborator Author

We can consider doing this for Buildroot 2020.02 LTS, it's not a big code change - just a decision

@afbjorklund afbjorklund removed the help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. label Feb 16, 2020
@Divya063
Copy link

/assign

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 13, 2020
@fejta-bot
Copy link

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Sep 12, 2020
@sharifelgamal sharifelgamal added lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. and removed lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. labels Sep 16, 2020
@priyawadhwa priyawadhwa added priority/backlog Higher priority than priority/awaiting-more-evidence. and removed priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. labels Jan 25, 2021
@afbjorklund
Copy link
Collaborator Author

I don't think we will do this, but could consider it for #11056

@afbjorklund afbjorklund added triage/discuss Items for discussion and removed good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. labels Apr 10, 2021
@sharifelgamal
Copy link
Collaborator

I'm actually in favor of this, I would approve a PR that makes that change.

@sharifelgamal sharifelgamal removed the triage/discuss Items for discussion label Apr 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/guest-vm General configuration issues with the minikube guest VM kind/feature Categorizes issue or PR as related to a new feature. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. priority/backlog Higher priority than priority/awaiting-more-evidence.
Projects
None yet
Development

No branches or pull requests

8 participants