Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider using TUF for update checks and downloading the ISO/localkube binaries #508

Closed
dlorenc opened this issue Aug 22, 2016 · 6 comments
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.

Comments

@dlorenc
Copy link
Contributor

dlorenc commented Aug 22, 2016

If this is a FEATURE REQUEST, please:

  • Describe in detail the feature/behavior/change you'd like to see.

See details here: https://theupdateframework.github.io/

There's a Go library here: https://github.com/flynn/go-tuf

@dlorenc dlorenc added the kind/feature Categorizes issue or PR as related to a new feature. label Aug 22, 2016
@r2d4
Copy link
Contributor

r2d4 commented Aug 22, 2016

SGTM. This would be a lot better and more secure than trying to roll our own.

What are the key differences between flynn/go-tuf and docker/notary? Seems like they are both go implementations of TUF.

@philips
Copy link
Contributor

philips commented Sep 13, 2016

cc @ecordell

@ecordell
Copy link

ecordell commented Sep 13, 2016

Notary is actually a fork of go-tuf that implements more of the TUF spec and adds a few things on top of it (db storage support and a server/signer/client split) to support a production deployment. The tuf folder in the notary repo is almost exactly the same as go-tuf (IMO this should be upstreamed, but if you look through the GH issues/commits there was some point where they felt it had diverged too much; IIRC mainly by deprecating the command-line tuf client and replacing it with the server-aware notary client).

In my opinion: If the plan is for maintainers to be very hands-on with the TUF metadata, go-tuf is a fine choice because it gives you a simple tool to modify a set of TUF metadata files, which you can then host statically and clients can pull and verify. TUF is designed with this simple case in mind, and a cron job or something can update the timestamp metadata (which would be the only online key in the simple case). If you instead need to support multiple users modifying metadata, coordinating signing, etc, I think notary is a better choice.

@fejta-bot
Copy link

Issues go stale after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

Prevent issues from auto-closing with an /lifecycle frozen comment.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or @fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 17, 2017
@fejta-bot
Copy link

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or @fejta.
/lifecycle rotten
/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jan 16, 2018
@fejta-bot
Copy link

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.
Projects
None yet
Development

No branches or pull requests

6 participants