Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect --extra-config issues immediately rather than waiting 10 minutes #4806

Closed
tstromberg opened this issue Jul 18, 2019 · 5 comments · Fixed by #7104
Closed

Detect --extra-config issues immediately rather than waiting 10 minutes #4806

tstromberg opened this issue Jul 18, 2019 · 5 comments · Fixed by #7104
Assignees
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.

Comments

@tstromberg
Copy link
Contributor

If a user feeds bad data into apiserver, the apiserver crashes immediately with messages that can be found using minikube logs --problems.

 ~  minikube logs --problems                                  Thu 18 Jul 2019 09:29:35 AM PDT
❌  Problems detected in "kube-apiserver":
    error: invalid audit log mode 777, allowed modes are "batch,blocking,blocking-strict"
❌  Problems detected in "kube-addon-manager":
    error: unable to recognize "STDIN": Get https://localhost:8443/api?timeout=32s: dial tcp 127.0.0.1:8443: connect: connection refused
    error: unable to recognize "STDIN": Get https://localhost:8443/api?timeout=32s: dial tcp 127.0.0.1:8443: connect: connection refused
    error: unable to recognize "STDIN": Get https://localhost:8443/api?timeout=32s: dial tcp 127.0.0.1:8443: connect: connection refused

This makes experimentation hard. Instead of telling users about it immediately, we currently make them wait ~8 minutes. We can do better :)

@tstromberg tstromberg added the help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. label Jul 18, 2019
@tstromberg
Copy link
Contributor Author

Example command-line:

minikube start --extra-config=apiserver.audit-dynamic-configuration=true --extra-config=apiserver.audit-policy-file=- --extra-config=apiserver.audit-log-path=- --extra-config=apiserver.audit-log-mode=777 --extra-config=apiserver.audit-log-maxage=5 --extra-config=apiserver.audit-log-maxbackup=5 --feature-gates=DynamicAuditing=true

@tstromberg tstromberg added kind/feature Categorizes issue or PR as related to a new feature. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. labels Jul 18, 2019
@tstromberg
Copy link
Contributor Author

@olivierlemasle
Copy link
Member

This delay before failure is actually due to Kubeadm. I logged an issue there, that was closed because it's not currently possible: kubernetes/kubeadm#1690

@tstromberg tstromberg changed the title Detect --extra-config issues immediately rather than waiting 8 minutes Detect --extra-config issues immediately rather than waiting 10 minutes Aug 2, 2019
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 31, 2019
@tstromberg tstromberg added lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Nov 1, 2019
@tstromberg
Copy link
Contributor Author

Still an issue in minikube v1.6.

When we are waiting for the apiserver to become healthy, it would be nice to notice these failures and surface them in real time. Help wanted!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants