Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Minikube should read lowercase http_proxy too #4600

Closed
dfang opened this issue Jun 26, 2019 · 2 comments · Fixed by #4602
Closed

[Feature Request] Minikube should read lowercase http_proxy too #4600

dfang opened this issue Jun 26, 2019 · 2 comments · Fixed by #4602
Assignees
Labels
cause/firewall-or-proxy When firewalls or proxies seem to be interfering priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.

Comments

@dfang
Copy link
Contributor

dfang commented Jun 26, 2019

The exact command to reproduce the issue:
minikube start

The full output of the command that failed:

not failed, this is for better usability, for many reasons, users in china must use proxy to pull image from gcr.io ....

currently most applications(curl, wget, git etc) read lowercase http_proxy env, or read both lowercase and uppercase, maybe minikube should support read lowercase http_proxy too if HTTP_PROXY not set but http_proxy is set ....

related issue: #2453

The operating system version:

macOS 10.14.5

minikube 1.2.0

@dfang dfang changed the title Minikube should read lowercase http_proxy too [Feature Request] Minikube should read lowercase http_proxy too Jun 26, 2019
@medyagh medyagh self-assigned this Jun 26, 2019
@medyagh
Copy link
Member

medyagh commented Jun 26, 2019

Thank you for reporting this issue, I will make sure this is resolved.

@medyagh medyagh added cause/firewall-or-proxy When firewalls or proxies seem to be interfering priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. labels Jun 26, 2019
@dfang
Copy link
Contributor Author

dfang commented Jun 26, 2019

@medyagh Thanks for your quick response,

i think these issues (#4167, #4594) is related to usability too,

because proxy, dns, registry mirrors have impact on pulling images, that is usability, i really heard many people complains that. There are so many issues about pulling images failed, hyperkit: tcp: lookup k8s.gcr.io read: connection refused .... i'm also always struggling on this from last year, sometimes i made it work, sometimes didn't ... and minikube updates... anyway many bad experiences on minikube, switched to docker for mac for a while, now switched back as minikube have load balancer and multi-profile support, so i wish minikube team could improve usability ...

let me know if you need any logs for diagnosis

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cause/firewall-or-proxy When firewalls or proxies seem to be interfering priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants