Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for VM-free deployments using Docker #4389

Closed
tstromberg opened this issue May 30, 2019 · 7 comments
Closed

Add support for VM-free deployments using Docker #4389

tstromberg opened this issue May 30, 2019 · 7 comments
Assignees
Labels
kind/feature Categorizes issue or PR as related to a new feature. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. roadmap/2019 Items on the 2019 roadmap
Milestone

Comments

@tstromberg
Copy link
Contributor

This will give a much better user experience for folks in nested VM's than the "none" driver currently provides.

If possible, this should be done in collaboration with the fine folks at https://github.com/kubernetes-sigs/kind

@tstromberg tstromberg added roadmap/2019 Items on the 2019 roadmap kind/feature Categorizes issue or PR as related to a new feature. labels May 30, 2019
@afbjorklund
Copy link
Collaborator

Do we really have to write multiple implementations, or can we use something like CRI from the start ?

Like https://kind.sigs.k8s.io/docs/design/principles#target-cri-functionality (and to avoid that extra work)

@afbjorklund
Copy link
Collaborator

See this kind Dockerfile for some of the crazy stuff needed, when running systemd in a container:
https://github.com/kubernetes-sigs/kind/blob/master/images/base/Dockerfile (based on Ubuntu)

This issue (VM-free deployments) is likely to have to work with changes to libmachine and buildroot...
As in: it is not certain that we will keep the docker-machine API and the minikube ISO, while doing it.


The "none" driver isn't really a VM-free environment, it's just intended to run on a pre-allocated VM.

This issue is different, since it doesn't require the user to do anything but provide a container runtime.
Then it will start containers "faking" nodes, and use those to start pods. (see e.g. the kind design doc)

That is something else than installing the kubelet on the local host. It also allows for multiple nodes.

@afbjorklund
Copy link
Collaborator

See also https://github.com/kubernetes/community/blob/master/contributors/design-proposals/cluster-lifecycle/local-cluster-ux.md for the original minikube proposal and some of the reasoning behind it...

@afbjorklund
Copy link
Collaborator

@medyagh : will you run a sshd in the "node" container, or should we use exec and nsenter instead ?

I was wondering about the minikube ssh use-case, as you know it is not supported by the none driver

@medyagh
Copy link
Member

medyagh commented Jul 16, 2019

I would user exec, which will invoke "docker exec"

I am implementing a specialized commander for the vm-free which is basically a helper for docker exec

@priyawadhwa
Copy link

This feature is expected to be done by next quarter.

@medyagh
Copy link
Member

medyagh commented Jan 13, 2020

the undocumented support for docker vm driver has been merged by #6151

I will close this issue and make smaller issues to be tracked for next steps of kic

@medyagh medyagh closed this as completed Jan 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. roadmap/2019 Items on the 2019 roadmap
Projects
None yet
Development

No branches or pull requests

4 participants