Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enables support for connection tracking zones (CONFIG_NF_CONNTRACK_ZONES) in the guest VM #3731

Closed
jojimt opened this issue Feb 21, 2019 · 7 comments
Labels
area/guest-vm General configuration issues with the minikube guest VM kind/feature Categorizes issue or PR as related to a new feature. priority/backlog Higher priority than priority/awaiting-more-evidence.

Comments

@jojimt
Copy link
Contributor

jojimt commented Feb 21, 2019

The mini-kube VM currently has
"# CONFIG_NF_CONNTRACK_ZONES is not set"

I have a need to use this feature and would like to update the VM image. Is there a recommended way to do this? Is there a way to include this feature by default? Any guidance is appreciated.

@afbjorklund
Copy link
Collaborator

That looks like a kernel configuration, so needs a new ISO built - with that change applied.
What is the feature used for, and why do you need it ? What are the downsides of enabling it ?

https://github.com/kubernetes/minikube/blob/master/docs/contributors/minikube_iso.md

@jojimt
Copy link
Contributor Author

jojimt commented Feb 22, 2019

Thanks for the pointer. Let me try that.
What is the feature used for, and why do you need it ? What are the downsides of enabling it ?

I am testing a firewall plugin that requires it. As for downside, it might use a small amount of additional memory. I can't think of anything else.

@tstromberg
Copy link
Contributor

I'm OK with reviewing a PR that includes this change.

@tstromberg tstromberg changed the title Minikube VM upgrade Enables support for connection tracking zones (CONFIG_NF_CONNTRACK_ZONES) in the guest VM Feb 22, 2019
@tstromberg tstromberg added kind/feature Categorizes issue or PR as related to a new feature. priority/backlog Higher priority than priority/awaiting-more-evidence. labels Feb 22, 2019
@jojimt
Copy link
Contributor Author

jojimt commented Feb 24, 2019

I am running into an issue with the kernel version while building it. I have:

ubuntu@ip-172-31-36-92:~/go/src/minikube$ uname -a
Linux ip-172-31-36-92 4.16.14-041614-generic #201806051643 SMP Tue Jun 5 16:45:47 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux

which is what the Makefile seems to call for:

ubuntu@ip-172-31-36-92:~/go/src/minikube$ grep KERNEL Makefile 
KERNEL_VERSION ?= 4.16.14

However, I get

ubuntu@ip-172-31-36-92:~/go/src/minikube$ make linux-menuconfig
make -C ./out/buildroot/output/build/linux-4.16.14/ menuconfig
make[1]: *** out/buildroot/output/build/linux-4.16.14/: No such file or directory.  Stop.

ubuntu@ip-172-31-36-92:~/go/src/minikube$ ls out/buildroot/output/build/linux-
linux-4.15/         linux-headers-4.15/

If I edit the Makefile to change the kernel version to 4.15, I am able to proceed. But, it looks like I am downgrading the kernel in the process which is not the intent.

Any ideas?

@jojimt
Copy link
Contributor Author

jojimt commented Feb 25, 2019

@tstromberg any suggestions on how to get the build to use linux-4.16.14?

@jojimt
Copy link
Contributor Author

jojimt commented Feb 25, 2019

It turns out that #2986 actually downgraded the kernel to 4.15, but left the Makefile and apparently the linux_defconfig still at 4.16.14. So, I will proceed with 4.15.

@afbjorklund afbjorklund added the area/guest-vm General configuration issues with the minikube guest VM label Feb 27, 2019
@tstromberg
Copy link
Contributor

tstromberg commented May 22, 2019

I believe this issue was resolved in the v1.0 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/guest-vm General configuration issues with the minikube guest VM kind/feature Categorizes issue or PR as related to a new feature. priority/backlog Higher priority than priority/awaiting-more-evidence.
Projects
None yet
Development

No branches or pull requests

3 participants