Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update podman to v1.0.0 #3568

Closed
tstromberg opened this issue Jan 22, 2019 · 5 comments
Closed

Update podman to v1.0.0 #3568

tstromberg opened this issue Jan 22, 2019 · 5 comments
Labels
area/guest-vm General configuration issues with the minikube guest VM good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.
Milestone

Comments

@tstromberg
Copy link
Contributor

It's out: https://podman.io/

It will require updating podman.mk, podman.hash, and going through https://github.com/kubernetes/minikube/blob/master/docs/contributors/minikube_iso.md

@tstromberg tstromberg added help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. area/code-deps Code dependencies (guest-vm deps belong in guest-vm) area/guest-vm General configuration issues with the minikube guest VM and removed area/code-deps Code dependencies (guest-vm deps belong in guest-vm) labels Jan 22, 2019
@tstromberg tstromberg modified the milestones: v1.0.0, v0.31.0 Jan 22, 2019
@tstromberg tstromberg added the priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. label Jan 22, 2019
@tstromberg tstromberg modified the milestones: v1.0.0, v1.0.0-candidate Jan 22, 2019
@afbjorklund
Copy link
Collaborator

Some of the required steps were done in the podman PR: #2757

@phoenixking25
Copy link

I got the idea that for this there would be changes first to change the version in podman.mk to v1.0.0 and another to change hash, but can anyone help me in how to get new hash to update.

@afbjorklund
Copy link
Collaborator

afbjorklund commented Jan 23, 2019

@phoenixking25 : will make a PR for this shortly (it needs some other fixes too), but basically sha256sum.

@afbjorklund
Copy link
Collaborator

afbjorklund commented Jan 23, 2019

Also need a better place to store the default registries, probably was not a good idea to include them in crio.

WARN[0000] unable to find /etc/containers/registries.conf. some podman (image shortnames) commands may be limited

Maybe we should add a "containers-common", or perhaps generate it at run-time like with crictl.yaml ?

[registries.search]
registries = ['docker.io']

[registries.insecure]
registries = []

@afbjorklund
Copy link
Collaborator

Scratch that, might as well keep the registries.conf with the already existing policy.json file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/guest-vm General configuration issues with the minikube guest VM good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.
Projects
None yet
Development

No branches or pull requests

3 participants