Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update /github.com/johanneswuerbach/nfsexports dependency to add LICENSE #3406

Closed
swinslow opened this issue Dec 4, 2018 · 0 comments
Closed
Assignees
Labels
area/code-deps Code dependencies (guest-vm deps belong in guest-vm) priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.

Comments

@swinslow
Copy link

swinslow commented Dec 4, 2018

Is this a BUG REPORT or FEATURE REQUEST? (choose one): Bug Report (sort of)

What happened: /vendor/github.com/johanneswuerbach/nfsexports doesn't contain a license for that dependency. That's because the upstream project previously didn't have either a LICENSE file or a license specified in their README or source code.

They've now added an MIT license (see johanneswuerbach/nfsexports#2)

What you expected to happen: The dependency should have a license 😃

Anything else do we need to know: Can you update the version of /github.com/johanneswuerbach/nfsexports/ that minikube is using, to pull a new version that includes the LICENSE file? Nothing else should have changed in the upstream repo, so I hope that this will be a minimal update.

@tstromberg tstromberg added the area/code-deps Code dependencies (guest-vm deps belong in guest-vm) label Dec 4, 2018
@tstromberg tstromberg added the priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. label Jan 23, 2019
@tstromberg tstromberg self-assigned this Jan 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/code-deps Code dependencies (guest-vm deps belong in guest-vm) priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Projects
None yet
Development

No branches or pull requests

2 participants