Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minikube not automatically added to PATH when using installer (Win7, PATH truncation?) #3053

Closed
StarfallProjects opened this issue Aug 7, 2018 · 10 comments
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/bug Categorizes issue or PR as related to a bug. os/windows packaging/windows Windows packaging issues priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. triage/duplicate Indicates an issue is a duplicate of other open issue.

Comments

@StarfallProjects
Copy link

Is this a BUG REPORT or FEATURE REQUEST? (choose one): Bug report

Environment:

Minikube version (use minikube version): 0.28.2

  • OS (e.g. from /etc/os-release): Windows 7
  • Install tools: Windows installer

What happened:

I had not previously installed minikube.

I downloaded and ran the Windows installer (minikube-installer.exe)

The installer ran, and various files were added to C:\Program Files (x86)\Kubernetes\Minikube

minikube.exe was not added to my PATH.

What you expected to happen:

I expected minikube to be automatically added to my PATH, as per the installtion guide:

Windows Installer [Experimental]
Download the minikube-installer.exe file, and execute the installer. This will automatically add minikube.exe to your path with an uninstaller available as well.

How to reproduce it (as minimally and precisely as possible):

Download and run the installer on Windows 7, for a fresh install.

@Vaskinn
Copy link

Vaskinn commented Aug 16, 2018

I just ran into this issue. It appears that the installer truncated my path to 1024 characters. This is somewhat serious since not only does minikube fail to work as expected but it also breaks other programs in the process.

@tstromberg tstromberg changed the title Minikube not automatically added to PATH when using installer Minikube not automatically added to PATH when using installer (Win7, PATH truncation?) Sep 18, 2018
@tstromberg
Copy link
Contributor

@tstromberg tstromberg added the kind/bug Categorizes issue or PR as related to a bug. label Sep 19, 2018
@tstromberg
Copy link
Contributor

@StarfallProjects - Do you mind sharing your current PATH value? I'm curious if truncation is coming into play for you.

@tstromberg tstromberg added packaging/windows Windows packaging issues and removed area/product-excellence packaging Packaging issues labels Sep 19, 2018
@StarfallProjects
Copy link
Author

So I went and manually added it to get the thing working, so not sure if this is helpful - am a kubernetes noob. But this is everything in my PATH now:

C:\Users\Deborah\AppData\Local\Programs\Python\Python36-32\Scripts;C:\Users\Deborah\AppData\Local\Programs\Python\Python36-32;C:\Ruby24-x64\bin;C:\Users\Deborah\AppData\Local\GitHub\PortableGit_c7e0cbde92ba565cb218a521411d0e854079a28c\cmd\git.exe;C:\hugo\bin;C:\Progra~1\Java\jdk1.8.0_91;C:\Python27;C:\Users\Deborah\AppData\Local\Programs\Fiddler;C:\Program Files\Sublime Text 3;C:\PHP;C:\Users\Deborah\AppData\Roaming\Composer\vendor\bin;C:\SQLite;C:\Go;C:\Users\Deborah\Desktop\GoWorkspace\bin;C:\Program Files\Microsoft VS Code\bin;C:\Users\Deborah\AppData\Roaming\npm;C:\Program Files\Docker Toolbox;C:\Program Files\Java\jre1.8.0_151;C:\Program Files\Selenium\chromedriver.exe;C:\Program Files\MongoDB\Server\3.6\bin;C:\Program Files\Maven\apache-maven-3.5.3\bin;C:\MySQL\bin;C:\Users\Deborah\ngrok;C:\dep\bin;C:\Users\Deborah\AppData\Local\Programs\Python\Python36-32\Scripts;C:\kubeless;C:\Program Files (x86)\Kubernetes\Minikube;C:\Users\Deborah\AppData\Local\Yarn\bin;C:\Program Files\heroku\bin;C:\flutter\bin

Before I added it manually, it simply wasn't there at all (i.e. no part of C:\Program Files (x86)\Kubernetes\Minikube; got added)

@tstromberg
Copy link
Contributor

@StarfallProjects Thanks for sharing! It looks like your PATH is now 1021 characters, which may cause future breakage as the normal methods for updating environment variables are capped at 1024.

Anways, this is a bug and we can do better here. Thanks for opening this issue!

@yarix
Copy link

yarix commented Oct 9, 2018

FYI - I've encountered similar issue with minikube-installer.exe v0.30.0 on win10.
after completing the installation, the PATH was not updated properly. instead of adding C:\Program Files (x86)\Kubernetes\Minikube to the PATH, it added just C:\Prog...
I've fixed the PATH manually and all works fine.

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 7, 2019
@tstromberg tstromberg added help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jan 23, 2019
@tstromberg
Copy link
Contributor

Dupe of #2587

@tstromberg tstromberg added the triage/duplicate Indicates an issue is a duplicate of other open issue. label Jan 24, 2019
@kajariagrawal
Copy link

Faced this issue on m windows 7. Again, path not added. I added it manually and it works now. My doubt is haven't they fixed it yet? the bug is reported a year back.

@Sweta-sweta
Copy link

The term 'minikube' is not recognized as the name of a cmdlet, function, script file, or operable program. Check the
spelling of the name, or if a path was included, verify that the path is correct and try again.
At line:1 char:1

  • minikube start

I downloaded minikube.exe file and added it my systems path still this error is coming.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/bug Categorizes issue or PR as related to a bug. os/windows packaging/windows Windows packaging issues priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. triage/duplicate Indicates an issue is a duplicate of other open issue.
Projects
None yet
Development

No branches or pull requests

8 participants