Cannot deploy v1.11.0 because minikube puts bad default parameters in kube-apiserver manifest

[Arnavion]

Is this a BUG REPORT or FEATURE REQUEST? (choose one): BUG REPORT

Please provide the following details:

Environment: Windows 7

Minikube version (use minikube version): 0.28.0

• OS (e.g. from /etc/os-release): Windows 7
• VM Driver (e.g. cat ~/.minikube/machines/minikube/config.json | grep DriverName): virtualbox
• ISO version (e.g. cat ~/.minikube/machines/minikube/config.json | grep -i ISO or minikube ssh cat /etc/VERSION): v0.28.0
• Install tools:
• Others:

What happened:

/var/lib/kubeadm.yaml is created with

apiServerExtraArgs:
    admission-control: ...

because of https://github.com/kubernetes/minikube/blob/3e267fd5/pkg/minikube/bootstrapper/kubeadm/versions.go#L202-L209 , but 1.11.0 also defaults to adding --enable-admission-plugins and --disable-admission-plugins because of kubernetes/kubernetes#64165

Thus kubeadm creates /etc/kubernetes/manifests/kube-apiserver.yaml with both sets of parameters. So kube-apiserver keeps failing to start with admission-control and enable-admission-plugins/disable-admission-plugins flags are mutually exclusive, and deployment eventually fails.

What you expected to happen:

minikube start succeeds.

How to reproduce it (as minimally and precisely as possible):

minikube start --kubernetes-version v1.11.0

Output of minikube logs (if applicable):

Anything else do we need to know:

[dlorenc]

So to be clear the fix is to remove the admission-control flag for 1.11.0 clusters?

[Arnavion]

Yes, perhaps by adding a LessThanOrEqual: semver.MustParse("1.10.*")