kubeadm bootstrapper does not support kubelet extra-config

[kevindrosendahl]

Is this a BUG REPORT or FEATURE REQUEST? (choose one):

bug report

Please provide the following details:

Environment:

Minikube version (use minikube version): v0.22.3

• OS (e.g. from /etc/os-release): OS X 10.12.6
• VM Driver (e.g. cat ~/.minikube/machines/minikube/config.json | grep DriverName): virtualbox
• ISO version (e.g. cat ~/.minikube/machines/minikube/config.json | grep -i ISO or minikube ssh cat /etc/VERSION): v0.23.5

What happened:

minikube start --bootstrapper kubeadm --kubernetes-version v1.8.0 --extra-config=kubelet.resolv-conf=/tmp/local-k8s-resolv.conf fails with the following error:

E1013 14:18:21.261439   13075 start.go:218] Error updating cluster:  generating kubeadm cfg: generating extra component config for kubeadm: Unknown component map[apiserver:apiServerExtraArgs scheduler:schedulerExtraArgs controller-manager:controllerManagerExtraArgs].  Valid components and kubeadm config are map[apiserver:apiServerExtraArgs scheduler:schedulerExtraArgs controller-manager:controllerManagerExtraArgs]

What you expected to happen:

The kubelet to be configured with the specified extra config.

How to reproduce it (as minimally and precisely as possible):

Run minikube start --bootstrapper kubeadm --kubernetes-version v1.8.0 --extra-config=kubelet.resolv-conf=/tmp/local-k8s-resolv.conf

Output of minikube logs (if applicable):

N/A

Anything else do we need to know:

I may be getting the syntax wrong (#2034) but regardless I believe that the kubelet is not currently supported, as it is not an expected extraOption component in kubeadm.NewComponentExtraArgs:

minikube/pkg/minikube/bootstrapper/kubeadm/versions.go

Lines 63 to 89 in 8dbe63d

	var componentToKubeadmConfigKey = map[string]string{
	Apiserver: "apiServerExtraArgs",
	Scheduler: "schedulerExtraArgs",
	ControllerManager: "controllerManagerExtraArgs",
	}
	func NewComponentExtraArgs(opts util.ExtraOptionSlice, version semver.Version) ([]ComponentExtraArgs, error) {
	var kubeadmExtraArgs []ComponentExtraArgs
	for _, extraOpt := range opts {
	kubeadmKey, ok := componentToKubeadmConfigKey[extraOpt.Component]
	if !ok {
	return nil, fmt.Errorf("Unknown component %s. Valid components and kubeadm config are %v", componentToKubeadmConfigKey, componentToKubeadmConfigKey)
	}
	extraConfig, err := ExtraConfigForComponent(extraOpt.Component, opts, version)
	if err != nil {
	return nil, errors.Wrapf(err, "getting kubeadm extra args for %s", extraOpt.Component)
	}
	if len(extraConfig) > 0 {
	kubeadmExtraArgs = append(kubeadmExtraArgs, ComponentExtraArgs{
	Component: kubeadmKey,
	Options: extraConfig,
	})
	}
	}
	return kubeadmExtraArgs, nil
	}

(edited slightly to fix minikube start command)

[r2d4]

Good catch, this is fixed in #2037

[kevindrosendahl]

Ah, missed that somehow, thanks!

[Morriz]

This still fails for me if I start with:

minikube start \
    --kubernetes-version v1.8.1 \
    --bootstrapper kubeadm \
    --v 10 \
    --logtostderr \
    --extra-config=apiserver.Admission.PluginNames="Initializers,NamespaceLifecycle,LimitRanger,ServiceAccount,DefaultStorageClass,GenericAdmissionWebhook,ResourceQuota,PodPreset"
    --registry-mirror=http://localhost:6000

The boot script hangs and the api-server does not start correctly. I see :8443: getsockopt: connection refused errors in the journal.

If I leave the --extra-config part out it boots correctly, but I can't use my flags ;p

I'm on OSX 10.12.6