Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

site: make tabbed view linkable #18956

Closed
medyagh opened this issue May 24, 2024 · 6 comments
Closed

site: make tabbed view linkable #18956

medyagh opened this issue May 24, 2024 · 6 comments
Assignees
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.

Comments

@medyagh
Copy link
Member

medyagh commented May 24, 2024

What Happened?

for example in these pages we have Tabs
https://minikube.sigs.k8s.io/docs/start/
for example we have linux mac windows tabs here
https://minikube.sigs.k8s.io/docs/handbook/addons/ingress-dns/

when we click on the Active Tab we should be able to link to the Tab we want in order to give to another person, lets say I wanna only link to the Windows there should be a way to link to it regardless of the user click

Attach the log file

n/a

Operating System

None

Driver

None

@medyagh medyagh added help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. labels May 24, 2024
@rihib rihib removed their assignment May 27, 2024
@hritesh04
Copy link
Contributor

hritesh04 commented May 28, 2024

can i work on this ? @medyagh

@hritesh04
Copy link
Contributor

/assign

@medyagh
Copy link
Member Author

medyagh commented May 28, 2024

@hritesh04 sorry had to revert your PR while it looked good when selecting a tab but it was broken on the index see the preview

https://deploy-preview-18977--kubernetes-sigs-minikube.netlify.app/docs/start/

@spowelljr
Copy link
Member

Hi @hritesh04, regarding the revert, I believe the issue is due to moving setting the default selection into an else:

const archParam = urlParams.get("arch");

//checks for query params and process each option one by one

if (archParam) {
    ...
} else {
    // auto-select the OS for user
    const btn = $(".option-button[data-quiz-id='/" + userOS + "']").first();
    btn.addClass("active");
    selectQuizOption(btn.attr("data-quiz-id"));
}

It seems that archParam is resulting to true when it shouldn't

@hritesh04
Copy link
Contributor

hritesh04 commented May 28, 2024

hey @spowelljr ,
I think the issue was created when the site was accessed from a Mac. if so there was a issue on line 59 of quiz.js which i fixed and opened a pr for. Please check that #18982

@medyagh
Copy link
Member Author

medyagh commented May 29, 2024

closed #18982

@medyagh medyagh closed this as completed May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.
Projects
None yet
Development

No branches or pull requests

4 participants