Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a confirmation for minikube delete #1683

Closed
javajon opened this issue Jul 10, 2017 · 1 comment
Closed

Add a confirmation for minikube delete #1683

javajon opened this issue Jul 10, 2017 · 1 comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@javajon
Copy link

javajon commented Jul 10, 2017

After executing minikube delete namespace <foo> the command ignored the extra parameters and indeed deleted the Minikube instance.

Of course, that was wrong as I meant to issue kubectl delete namespace <foo>. But, it's too late and my error is not recoverable or undoable.

Given that minikube delete is a permanent action (visualize death star) and can easily be substituted with the less destructive kubectl delete x perhaps an added safeguard confirmation for delete might be appreciated.

@r2d4
Copy link
Contributor

r2d4 commented Jul 10, 2017

This makes sense. We should probably ensure that minikube delete either takes no args or just the machine name

@r2d4 r2d4 added the kind/feature Categorizes issue or PR as related to a new feature. label Jul 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

No branches or pull requests

3 participants