Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Successfully downloaded all kic artifacts when not using KIC driver #16421

Closed
spowelljr opened this issue May 2, 2023 · 0 comments · Fixed by #16420
Closed

Successfully downloaded all kic artifacts when not using KIC driver #16421

spowelljr opened this issue May 2, 2023 · 0 comments · Fixed by #16420
Assignees
@spowelljr
Labels
co/docker-driver Issues related to kubernetes in container kind/bug Categorizes issue or PR as related to a bug. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Milestone
1.31.0

Comments

@spowelljr
Copy link
Member

If you run --download-only on a none kic driver the following is output, which is misleading:

I0502 15:19:50.838287   54902 binary.go:76] Not caching binary, using https://dl.k8s.io/release/v1.26.3/bin/darwin/arm64/kubectl?checksum=file:https://dl.k8s.io/release/v1.26.3/bin/darwin/arm64/kubectl.sha256
I0502 15:19:50.838298   54902 cache.go:193] Successfully downloaded all kic artifacts
I0502 15:19:50.842395   54902 out.go:177] ✅  Download complete!
@spowelljr spowelljr added kind/bug Categorizes issue or PR as related to a bug. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. co/docker-driver Issues related to kubernetes in container labels May 2, 2023
@spowelljr spowelljr added this to the 1.31.0 milestone May 2, 2023
@spowelljr spowelljr self-assigned this May 2, 2023
@spowelljr spowelljr mentioned this issue May 2, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@spowelljr spowelljr

Labels
co/docker-driver Issues related to kubernetes in container kind/bug Categorizes issue or PR as related to a bug. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Projects
None yet
Milestone
1.31.0
Development

Successfully merging a pull request may close this issue.

Only wait for KIC base image when using KIC driver spowelljr/minikube
1 participant
@spowelljr