Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent users from modifying addons while cluster is paused #15857

Closed
spowelljr opened this issue Feb 14, 2023 · 7 comments · Fixed by #15868
Closed

Prevent users from modifying addons while cluster is paused #15857

spowelljr opened this issue Feb 14, 2023 · 7 comments · Fixed by #15868
Assignees
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/improvement Categorizes issue or PR as related to improving upon a current feature. priority/backlog Higher priority than priority/awaiting-more-evidence.

Comments

@spowelljr
Copy link
Member

spowelljr commented Feb 14, 2023

Currently you can try enabling/disabling an addon while the cluster is paused, but it will hang. We should prevent users from doing this and notify them that they can't perform this action while the cluster is paused and they should unpause the cluster if they wish to modify the addons.

Example:

$ minikube start
$ minikube pause
$ minikube addons enable gcp-auth
# hangs
@spowelljr spowelljr added help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. priority/backlog Higher priority than priority/awaiting-more-evidence. good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. kind/improvement Categorizes issue or PR as related to improving upon a current feature. labels Feb 14, 2023
@norshtein
Copy link
Contributor

/assign

@norshtein
Copy link
Contributor

Hey @spowelljr , may I take this work item?

I plan to add a check whether kube-system namespace is paused in EnableOrDisableAddon, that is adding runtimePaused, err = cluster.CheckIfPaused(runner, []string{"kube-system"}) here. If paused, then raise an error. Is this correct way to fix the issue?

@swastik959
Copy link
Contributor

@norshtein I tried the same way but for some reason it is not working

@spowelljr
Copy link
Member Author

@norshtein I believe that should work, that seems fine to me.

@ashutosh887
Copy link

I would like to work on this @spowelljr

@spowelljr
Copy link
Member Author

@ashutosh887 There is already a Pr create for this issue by @norshtein #15868

@akstron
Copy link

akstron commented Jun 7, 2023

@spowelljr Seems like no one is working on #15868 for a long time. I would like to work on this issue, if possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/improvement Categorizes issue or PR as related to improving upon a current feature. priority/backlog Higher priority than priority/awaiting-more-evidence.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants