Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

minikube tunnel should not be allowed to run twice #15825

Closed
medyagh opened this issue Feb 9, 2023 · 6 comments · Fixed by #15834
Closed

minikube tunnel should not be allowed to run twice #15825

medyagh opened this issue Feb 9, 2023 · 6 comments · Fixed by #15834
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.

Comments

@medyagh
Copy link
Member

medyagh commented Feb 9, 2023

What Happened?

right now we can run minikube tunnel in two different terminals two times ! which makes no sense

(follow example of Loadbalancer in site)
https://minikube.sigs.k8s.io/docs/start/

we should tell user another instance of minikube tunnel is running and exit safely

Attach the log file

na

Operating System

None

Driver

None
@medyagh medyagh added help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. labels Feb 9, 2023
@OmSaran
Copy link
Contributor

OmSaran commented Feb 10, 2023

I'm a student at UT Austin taking the virtualization course and as part of it, can I take a stab at this?

@swastik959
Copy link
Contributor

hi I want to contribute to this issue van you please explain it to me

@Sajiyah-Salat
Copy link

Hello @medyagh we need to add a warning line saying " Two tunnels are running". Can you please guide me to exact file?

@OmSaran
Copy link
Contributor

OmSaran commented Feb 12, 2023 •
edited
Loading

Hi @medyagh , what if a user wants to run a new tunnel on a new interface that was not tunneled by the older tunnel process? Would it make sense to have multiple tunnel processes running simultaneously in this case where the new tunnel binds to a new interface?

If you still think it is necessary to allow only 1 tunnel process to run, then how do you suggest we ensure that? I can think of using a file lock to ensure only one instance is running. Is that approach ok?

@OmSaran OmSaran mentioned this issue Feb 12, 2023
Merged
@OmSaran
Copy link
Contributor

OmSaran commented Feb 12, 2023

@medyagh I have created a PR (#15834) with the above mentioned approach, please review it.

@ashutosh887
Copy link

@medyagh Please check @here and let me know if I can help

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Ensure only one instance of tunnel process runs OmSaran/minikube
5 participants
@medyagh @OmSaran @swastik959 @ashutosh887 @Sajiyah-Salat