Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make docker cruntime also look for dockerd & cri-dockerd #14460

Closed
spowelljr opened this issue Jun 28, 2022 · 7 comments · Fixed by #14555
Closed

Make docker cruntime also look for dockerd & cri-dockerd #14460

spowelljr opened this issue Jun 28, 2022 · 7 comments · Fixed by #14555
Assignees
Labels
co/none-driver co/runtime/docker Issues specific to a docker runtime good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/improvement Categorizes issue or PR as related to improving upon a current feature. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.

Comments

@spowelljr
Copy link
Member

As suggested by @afbjorklund #14410 (comment)

We only check for docker, not dockerd & cri-dockerd, this will let the user know earlier on that they don't have all the requirements to run the docker container runtime.

@spowelljr spowelljr added co/runtime/docker Issues specific to a docker runtime co/none-driver priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. kind/improvement Categorizes issue or PR as related to improving upon a current feature. labels Jun 28, 2022
@spowelljr spowelljr added help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. labels Jun 28, 2022
@Gimb0
Copy link
Contributor

Gimb0 commented Jun 29, 2022

/assign

@afbjorklund
Copy link
Collaborator

Note: the cri-dockerd server is only needed for k8s 1.24 and later, see the checks done when selecting CRI or not

@klaases
Copy link
Contributor

klaases commented Jul 11, 2022

Hi @afbjorklund, I was looking through the codebase when I found .github/workflows/master.yml which on line 509 states: # cri-dockerd is required for Kubernetes 1.24 and higher for none driver.

Per your comment above, does minikube already enforce k8s 1.24+ for cri-dockerd?

I am working on PR to address this issue: #14555, and was curious whether I needed to manually check for k8s 1.24+.

@afbjorklund
Copy link
Collaborator

afbjorklund commented Jul 12, 2022

Per your comment above, does minikube already enforce k8s 1.24+ for cri-dockerd?

It starts the service and configures the socket, but it does not install it for you

Earlier versions of k8s included docker support, without extra installation

@klaases
Copy link
Contributor

klaases commented Jul 14, 2022

Hi @afbjorklund, thanks for your response, I've added a check for k8s >= 1.24 in #14555 which should resolve this.

@klaases
Copy link
Contributor

klaases commented Sep 10, 2022

Closing out for now as I have fixed this in #14555, thank you!

@klaases klaases closed this as completed Sep 10, 2022
@DanielViniciusAlves
Copy link

Hi, so I'm trying to understand the workflow of the minikube project and since there are no Good First Issue open without someone already assign I'm going through closed issue. Could someone explain to me what was the problem and how it was fixed? I already read the pr that fixed but had some trouble understanding!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
co/none-driver co/runtime/docker Issues specific to a docker runtime good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/improvement Categorizes issue or PR as related to improving upon a current feature. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants