Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve ingress & ingress-dns: restore backwards compatibility for k8s < v1.19 + fix --watch-ingress-without-class flag #12793

Closed
prezha opened this issue Oct 27, 2021 · 0 comments · Fixed by #12794
Closed

improve ingress & ingress-dns: restore backwards compatibility for k8s < v1.19 + fix --watch-ingress-without-class flag #12793

prezha opened this issue Oct 27, 2021 · 0 comments · Fixed by #12794

Comments

@prezha
Copy link
Contributor

prezha commented Oct 27, 2021

minikube tries to support the last 6 minor k8s versions and the newer ingress controller (v1+) introduced breaking changes requiring k8s >=v1.19

also, I've made a mistake in my previous pr #12702 enabling --watch-ingress-without-class flag for ingress api vi1beta1 instead of v1
@prezha prezha mentioned this issue Oct 27, 2021
Merged
@prezha prezha changed the title improve ingress: restore backwards compatibility for k8s < v1.19 + fix --watch-ingress-without-class flag improve ingress & ingress-dns: restore backwards compatibility for k8s < v1.19 + fix --watch-ingress-without-class flag Oct 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

support k8s < v1.19 & watch-ingress-without-class prezha/minikube
1 participant
@prezha