Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support multiple --mount-string arguments #12733

Open
mans0954 opened this issue Oct 19, 2021 · 5 comments
Open

Support multiple --mount-string arguments #12733

mans0954 opened this issue Oct 19, 2021 · 5 comments
Labels
area/mount kind/feature Categorizes issue or PR as related to a new feature. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. priority/backlog Higher priority than priority/awaiting-more-evidence.

Comments

@mans0954
Copy link

When run with the docker driver, minikube takes a --mount-string argument. Provided the minikube container does not yet exist, it is created with the specified host folder or docker volume mounted at the specified location e.g.

minikube start --mount  --mount-string "host_volume:/mount_point"

Mounts the host_volume docker volume at /mount_point in the minikube container.

In fact the --mount-string flag can be specified multiple times, but only the last specified is used.

A very small change to cmd/minikube/cmd/start_flags.go would allow multiple --mount-string arguments to be used.

@mans0954
Copy link
Author

/assign mans0954

@spowelljr spowelljr added area/mount kind/feature Categorizes issue or PR as related to a new feature. priority/backlog Higher priority than priority/awaiting-more-evidence. labels Oct 25, 2021
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 23, 2022
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Feb 22, 2022
@spowelljr spowelljr added lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. and removed lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. labels Feb 23, 2022
@spowelljr
Copy link
Member

One thing I'm not sure of is whether 9P supports multiple string arguments out of box or if we're going to have to loop over all the mount strings. Doesn't matter either way, but just something to think about.

@mans0954 mans0954 removed their assignment Jul 4, 2023
@mans0954
Copy link
Author

mans0954 commented Jul 4, 2023

I sketched out a solution to this in #12734 - I still think it would be a useful feature, but haven't had time to finish it myself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/mount kind/feature Categorizes issue or PR as related to a new feature. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. priority/backlog Higher priority than priority/awaiting-more-evidence.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants