Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run ingress addon on without the annotaion on the Ingress #12511

Closed
rubenvp8510 opened this issue Sep 18, 2021 · 4 comments · Fixed by #12794
Closed

Run ingress addon on without the annotaion on the Ingress #12511

rubenvp8510 opened this issue Sep 18, 2021 · 4 comments · Fixed by #12794
Labels
addon/ingress help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.

Comments

@rubenvp8510
Copy link

rubenvp8510 commented Sep 18, 2021

Steps to reproduce the issue:

  1. Execute minishift with ingress enable
  2. Apply an ingress object without annotation or IngressClass field
  3. Ingress controller fails with "removing ingress because of unknown ingressclass " and Ingress doesn't work at expected.

I would like to enable ingress add-on but I don't want to annotate all my ingress objects. Is there a way to enable --watch-ingress-without-class flag on the nginx ingress controller? I'm using minikube 1.23.1

https://kubernetes.github.io/ingress-nginx/#what-is-the-flag-watch-ingress-without-class

@rubenvp8510 rubenvp8510 changed the title Run ingress addon on unannotated Ingress Run ingress addon on without the annotaion on the Ingress Sep 22, 2021
@rubenvp8510
Copy link
Author

Any news on this?

The nginx ingress controller is supposed to run with this flags when there is the only ingress controller available, which I think is the case of minikube. This also require to bump ingress controller versions.

https://kubernetes.github.io/ingress-nginx/#i-have-only-one-instance-of-the-ingresss-nginx-controller-in-my-cluster-what-should-i-do

Thanks

@sharifelgamal sharifelgamal added addon/ingress help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. labels Sep 29, 2021
@sharifelgamal
Copy link
Collaborator

I see no reason why we can't support this, if someone wants to open a PR to fix this, I'd be happy to review.

@antoniordz96
Copy link

Correct me if I'm wrong but PR #12702 should address this issue. They are updating the ingress controller and adding the flag --watch-ingress-without-class=true.

@prezha
Copy link
Contributor

prezha commented Oct 27, 2021

@rubenvp8510 support for this should have been added in pr #12702 (as @antoniordz96 pointed out) but should then be "activated" in pr #12794 for v1 ingress api (requiring k8s version 1.19+) - please test it and report back the results, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
addon/ingress help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants