Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add configuration for buildkit, in order to not have to use flags #12264

Closed
afbjorklund opened this issue Aug 13, 2021 · 1 comment · Fixed by #12081
Closed

Add configuration for buildkit, in order to not have to use flags #12264

afbjorklund opened this issue Aug 13, 2021 · 1 comment · Fixed by #12081
Assignees
Labels
co/runtime/containerd kind/feature Categorizes issue or PR as related to a new feature. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Milestone

Comments

@afbjorklund
Copy link
Collaborator

afbjorklund commented Aug 13, 2021

We can pass the setup as configuration, rather than flags.

That makes it easier to start from systemd units, and so on.

We want to use the containerd worker, by default.

-oci-worker false --containerd-worker true

And store the result in the "k8s.io" namespace.

--containerd-worker-namespace k8s.io

Helps with #9947

@afbjorklund afbjorklund added kind/feature Categorizes issue or PR as related to a new feature. co/runtime/containerd labels Aug 13, 2021
@afbjorklund
Copy link
Collaborator Author

afbjorklund commented Aug 13, 2021

/etc/buildkit/buildkitd.toml

https://github.com/moby/buildkit/blob/master/docs/buildkitd.toml.md

[worker.oci]
  enabled = false
[worker.containerd]
  enabled = true
  namespace = "k8s.io"

Need to do this for both ISO and KIC installations of buildkit

@spowelljr spowelljr self-assigned this Sep 17, 2021
@spowelljr spowelljr added this to the 1.24.0 milestone Sep 17, 2021
@spowelljr spowelljr added the priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. label Sep 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
co/runtime/containerd kind/feature Categorizes issue or PR as related to a new feature. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants