Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cannot reconfigure metallb addon #12051

Closed
victor-sudakov opened this issue Jul 25, 2021 · 3 comments · Fixed by #12437
Closed

Cannot reconfigure metallb addon #12051

victor-sudakov opened this issue Jul 25, 2021 · 3 comments · Fixed by #12437
Assignees
@spowelljr
Labels
area/addons kind/improvement Categorizes issue or PR as related to improving upon a current feature. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Milestone
1.24.0

Comments

@victor-sudakov
Copy link

After configuring the metallb addon for the first time, I later decided to change the IP address range but have no idea how to "unconfigure" or "reconfigure" the addon without recreating the cluster from scratch:

$ minikube version
minikube version: v1.20.0
commit: c61663e942ec43b20e8e70839dcca52e44cd85ae
$ minikube addons configure metallb 
  - Using image metallb/speaker:v0.8.2
  - Using image metallb/controller:v0.8.2
* metallb was successfully configured

and that's it. How do I recall the interactive dialog about the IP range?
@RA489
Copy link

RA489 commented Jul 26, 2021

/kind support

@k8s-ci-robot k8s-ci-robot added the kind/support Categorizes issue or PR as a support question. label Jul 26, 2021
@spowelljr
Copy link
Member

spowelljr commented Sep 8, 2021 •
edited
Loading

Hi @victor-sudakovm thanks for reporting you issue with minikube!

The way the addon is currently configured it doesn't re-ask for the values if they're already set, as you've discovered. However, since the point of minikube addons configure is specifically asking to configure the value, I think this should be changed to always ask for the values.

As a work around for now you can open ~/.minikube/profiles/minikube/config.json and edit LoadBalancerStartIP and LoadBalancerEndIP manually and then run minikube addons enable metallb to generate the template manifest files.

@spowelljr spowelljr added kind/improvement Categorizes issue or PR as related to improving upon a current feature. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed kind/support Categorizes issue or PR as a support question. labels Sep 8, 2021
@spowelljr spowelljr self-assigned this Sep 8, 2021
@spowelljr spowelljr mentioned this issue Sep 8, 2021
Merged
@spowelljr spowelljr added this to the 1.24.0 milestone Sep 8, 2021
@spowelljr
Copy link
Member

My change fixing this is merged in, this will be fixed with the next release of minikube.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@spowelljr spowelljr

Labels
area/addons kind/improvement Categorizes issue or PR as related to improving upon a current feature. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Projects
None yet
Milestone
1.24.0
Development

Successfully merging a pull request may close this issue.

metallb addon: Ask user for config values even if already set spowelljr/minikube
4 participants
@victor-sudakov @k8s-ci-robot @RA489 @spowelljr