gcp-auth registries is too restrictive

[briandealwis]

The gcp-auth addon configures kubernetes.io/dockercfg secrets but only for gcr.io and us-docker.pkg.dev.

minikube/pkg/addons/addons_gcpauth.go

Lines 134 to 136 in 791e3b5

	data := map[string][]byte{
	".dockercfg": []byte(fmt.Sprintf(`{"https://gcr.io":{"username":"oauth2accesstoken","password":"%s","email":"none"}, "https://us-docker.pkg.dev":{"username":"oauth2accesstoken","password":"%s","email":"none"}}`, token.AccessToken, token.AccessToken)),
	}

We should either make this configurable or add support for a broader set of endpoints.

One approach would be to query GCR/AR for the list of registries visible to the account.

cc: @sharifelgamal

[sharifelgamal]

yeah good call, when I originally implemented gcp-auth I made the explicit choice to not worry about registry mirrors, now is a good time to fix that.

[briandealwis]

I followed up with the GCR/AR team and they suggested either hard-coding a list or taking a dependency on https://github.com/GoogleCloudPlatform/docker-credential-gcr/blob/faed5e8b8ca2a14e6cfff27ec915dbbdcce696ea/config/const.go#L49-L77